Re: [PATCH netdev-2.6 10/11] ixgb: Add copybreak

2006-03-03 Thread Arnaldo Carvalho de Melo
On 3/3/06, Herbert Xu <[EMAIL PROTECTED]> wrote: > Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > > > Also, you should use 2 rather than NET_IP_ALIGN here. > > The point of NET_IP_ALIGN is to allow architectures where unaligned > > DMA is expensive to redefine NET_IP_ALIGN to 0. But in this case

Re: [PATCH netdev-2.6 10/11] ixgb: Add copybreak

2006-03-02 Thread Herbert Xu
Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > Also, you should use 2 rather than NET_IP_ALIGN here. > The point of NET_IP_ALIGN is to allow architectures where unaligned > DMA is expensive to redefine NET_IP_ALIGN to 0. But in this case you > are not DMA'ing into the new buffer but using memcp

Re: [PATCH netdev-2.6 10/11] ixgb: Add copybreak

2006-03-02 Thread Stephen Hemminger
> + /* code added for copybreak, this should improve > + * performance for small packets with large amounts > + * of reassembly being done in the stack */ > +#define IXGB_CB_LENGTH 256 > + if (length < IXGB_CB_LENGTH) { > + stru

[PATCH netdev-2.6 10/11] ixgb: Add copybreak

2006-03-02 Thread Jeff Kirsher
- This patch adds the copybreak and skb recycle to the ixgb driver Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb.h |2 ++ drivers/net/ixgb/ixgb_main.c | 56 +