Re: [PATCH next-next 2/7] gre: Move utility functions to common headers

2016-05-04 Thread David Miller
From: Jiri Benc Date: Wed, 4 May 2016 10:35:49 +0200 > On Wed, 04 May 2016 00:53:16 -0400 (EDT), David Miller wrote: >> From: Jiri Benc >> Date: Tue, 3 May 2016 13:29:44 +0200 >> >> > How do we resolve the conflict between net and net-next? I'd prefer >> > gre_parse_header to return the header

Re: [PATCH next-next 2/7] gre: Move utility functions to common headers

2016-05-04 Thread Jiri Benc
On Wed, 04 May 2016 00:53:16 -0400 (EDT), David Miller wrote: > From: Jiri Benc > Date: Tue, 3 May 2016 13:29:44 +0200 > > > How do we resolve the conflict between net and net-next? I'd prefer > > gre_parse_header to return the header length. I can submit a patch for > > net-next that does this;

Re: [PATCH next-next 2/7] gre: Move utility functions to common headers

2016-05-03 Thread David Miller
From: Jiri Benc Date: Tue, 3 May 2016 13:29:44 +0200 > How do we resolve the conflict between net and net-next? I'd prefer > gre_parse_header to return the header length. I can submit a patch for > net-next that does this; that would substantially ease the merge. Jiri, I just did the net --> net

Re: [PATCH next-next 2/7] gre: Move utility functions to common headers

2016-05-03 Thread Jiri Benc
On Fri, 29 Apr 2016 17:12:16 -0700, Tom Herbert wrote: > - iptunnel_pull_header is taken out of gre_parse_header. This is now > done by caller. The header length is returned from gre_parse_header > in an int* argument. Seems we conflicted here, I've done the same for net.git to fix ICMP

[PATCH next-next 2/7] gre: Move utility functions to common headers

2016-04-29 Thread Tom Herbert
Several of the GRE functions defined in net/ipv4/ip_gre.c are usable for IPv6 GRE implementation (that is they are protocol agnostic). These include: - GRE flag handling functions are move to gre.h - GRE build_header is moved to gre.h and renamed gre_build_header - parse_gre_header is moved