Re: [PATCH v1 01/12] IB/core: pass client data to remove() callbacks

2015-07-14 Thread Haggai Eran
On 09/07/2015 00:34, Jason Gunthorpe wrote: > On Wed, Jul 08, 2015 at 02:29:10PM -0600, Jason Gunthorpe wrote: >> On Mon, Jun 22, 2015 at 03:42:30PM +0300, Haggai Eran wrote: >>> An ib_client callback that is called with the lists_rwsem locked only for >>> read is protected from changes to the IB c

Re: [PATCH v1 01/12] IB/core: pass client data to remove() callbacks

2015-07-08 Thread Jason Gunthorpe
On Wed, Jul 08, 2015 at 02:29:10PM -0600, Jason Gunthorpe wrote: > On Mon, Jun 22, 2015 at 03:42:30PM +0300, Haggai Eran wrote: > > An ib_client callback that is called with the lists_rwsem locked only for > > read is protected from changes to the IB client lists, but not from > > ib_unregister_dev

Re: [PATCH v1 01/12] IB/core: pass client data to remove() callbacks

2015-07-08 Thread Jason Gunthorpe
On Mon, Jun 22, 2015 at 03:42:30PM +0300, Haggai Eran wrote: > An ib_client callback that is called with the lists_rwsem locked only for > read is protected from changes to the IB client lists, but not from > ib_unregister_device() freeing its client data. This is because > ib_unregister_device() w

[PATCH v1 01/12] IB/core: pass client data to remove() callbacks

2015-06-22 Thread Haggai Eran
An ib_client callback that is called with the lists_rwsem locked only for read is protected from changes to the IB client lists, but not from ib_unregister_device() freeing its client data. This is because ib_unregister_device() will remove the device from the device list with lists_rwsem locked fo