Re: [PATCH v1 2/2] mei: bus: change remove callback to return void

2021-02-07 Thread kernel test robot
Hi "Uwe, I love your patch! Yet something to improve: [auto build test ERROR on 5c8fe583cce542aa0b84adc939ce85293de36e5e] url: https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/mei-bus-simplify-mei_cl_device_remove/20210208-062551 base: 5c8fe583cce542aa0b84adc939ce85293de36e5e conf

Re: [PATCH v1 2/2] mei: bus: change remove callback to return void

2021-02-07 Thread kernel test robot
Hi "Uwe, I love your patch! Yet something to improve: [auto build test ERROR on 5c8fe583cce542aa0b84adc939ce85293de36e5e] url: https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/mei-bus-simplify-mei_cl_device_remove/20210208-062551 base: 5c8fe583cce542aa0b84adc939ce85293de36e5e conf

Re: [PATCH v1 2/2] mei: bus: change remove callback to return void

2021-02-07 Thread kernel test robot
Hi "Uwe, I love your patch! Yet something to improve: [auto build test ERROR on 5c8fe583cce542aa0b84adc939ce85293de36e5e] url: https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/mei-bus-simplify-mei_cl_device_remove/20210208-062551 base: 5c8fe583cce542aa0b84adc939ce85293de36e5e conf

Re: [PATCH v1 2/2] mei: bus: change remove callback to return void

2021-02-07 Thread Guenter Roeck
On 2/7/21 2:22 PM, Uwe Kleine-König wrote: > The driver core ignores the return value of mei_cl_device_remove() so > passing an error value doesn't solve any problem. As most mei drivers' > remove callbacks return 0 unconditionally and returning a different value > doesn't have any effect, change t

[PATCH v1 2/2] mei: bus: change remove callback to return void

2021-02-07 Thread Uwe Kleine-König
The driver core ignores the return value of mei_cl_device_remove() so passing an error value doesn't solve any problem. As most mei drivers' remove callbacks return 0 unconditionally and returning a different value doesn't have any effect, change this prototype to return void and return 0 unconditi