Re: [PATCH v10 1/1] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces

2021-01-14 Thread Marc Kleine-Budde
On 1/15/21 1:41 AM, Vincent MAILHOL wrote: > On Fri. 15 Jan 2021 at 02:23, Oliver Hartkopp wrote: >> >> Hi Vincent, >> >> On 12.01.21 14:05, Vincent Mailhol wrote: >>> This driver supports the ES581.4, ES582.1 and ES584.1 interfaces from >>> ETAS GmbH (https://www.etas.com/en/products/es58x.php).

Re: [PATCH v10 1/1] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces

2021-01-14 Thread Vincent MAILHOL
On Fri. 15 Jan 2021 at 02:23, Oliver Hartkopp wrote: > > Hi Vincent, > > On 12.01.21 14:05, Vincent Mailhol wrote: > > This driver supports the ES581.4, ES582.1 and ES584.1 interfaces from > > ETAS GmbH (https://www.etas.com/en/products/es58x.php). > > (..) > > > diff --git a/drivers/net/can/usb/e

Re: [PATCH v10 1/1] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces

2021-01-14 Thread Oliver Hartkopp
Hi Vincent, On 12.01.21 14:05, Vincent Mailhol wrote: This driver supports the ES581.4, ES582.1 and ES584.1 interfaces from ETAS GmbH (https://www.etas.com/en/products/es58x.php). (..) diff --git a/drivers/net/can/usb/etas_es58x/es58x_fd.c b/drivers/net/can/usb/etas_es58x/es58x_fd.c new fil

Re: [PATCH v10 1/1] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces

2021-01-14 Thread Vincent MAILHOL
On Tue. 14 janv. 2021 at 01:04, Marc Kleine-Budde wrote: > > On 1/13/21 1:15 PM, Vincent MAILHOL wrote: > >>> +/** > >>> + * es58x_calculate_crc() - Compute the crc16 of a given URB. > >>> + * @urb_cmd: The URB command for which we want to calculate the CRC. > >>> + * @urb_len: Length of @urb_cmd.

Re: [PATCH v10 1/1] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces

2021-01-13 Thread Marc Kleine-Budde
On 1/13/21 3:35 PM, Vincent MAILHOL wrote: >> My understanding is that having a queue size being a power of two is >> required in order not to use spinlocks (else, modulo operations would >> break when the index wraparound back to zero). I tried to minimize the >> number of spinlock: only one per b

Re: [PATCH v10 1/1] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces

2021-01-13 Thread Marc Kleine-Budde
On 1/13/21 1:15 PM, Vincent MAILHOL wrote: >>> +/** >>> + * es58x_calculate_crc() - Compute the crc16 of a given URB. >>> + * @urb_cmd: The URB command for which we want to calculate the CRC. >>> + * @urb_len: Length of @urb_cmd. Must be at least bigger than 4 >>> + * (ES58X_CRC_CALC_OFFSET + siz

Re: [PATCH v10 1/1] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces

2021-01-13 Thread Vincent MAILHOL
On Wed. 13 Jan 2021 at 21:15, Vincent MAILHOL wrote: > > Hi Marc, > > Thanks for the comments! > > On Wed. 13 Jan 2021 à 18:33, Marc Kleine-Budde wrote: > > > > On 1/12/21 2:05 PM, Vincent Mailhol wrote: > > > This driver supports the ES581.4, ES582.1 and ES584.1 interfaces from > > > ETAS GmbH (

Re: [PATCH v10 1/1] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces

2021-01-13 Thread Vincent MAILHOL
Hi Marc, Thanks for the comments! On Wed. 13 Jan 2021 à 18:33, Marc Kleine-Budde wrote: > > On 1/12/21 2:05 PM, Vincent Mailhol wrote: > > This driver supports the ES581.4, ES582.1 and ES584.1 interfaces from > > ETAS GmbH (https://www.etas.com/en/products/es58x.php). > > > > Co-developed-by: Ar

Re: [PATCH v10 1/1] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces

2021-01-13 Thread Marc Kleine-Budde
On 1/12/21 2:05 PM, Vincent Mailhol wrote: > This driver supports the ES581.4, ES582.1 and ES584.1 interfaces from > ETAS GmbH (https://www.etas.com/en/products/es58x.php). > > Co-developed-by: Arunachalam Santhanam > Signed-off-by: Arunachalam Santhanam > Signed-off-by: Vincent Mailhol [...]

Re: [kbuild-all] Re: [PATCH v10 1/1] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces

2021-01-12 Thread Rong Chen
On 1/13/21 11:13 AM, Vincent MAILHOL wrote: On Tue 13 Jan 2021 at 00:29, kernel test robot wrote: Hi Vincent, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.11-rc3 next-20210111] [If your patch is applied to the wrong

Re: [PATCH v10 1/1] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces

2021-01-12 Thread Vincent MAILHOL
On Tue 13 Jan 2021 at 00:29, kernel test robot wrote: > > Hi Vincent, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v5.11-rc3 next-20210111] > [If your patch is applied to the wrong git tree, kindly drop us a note. >

Re: [PATCH v10 1/1] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces

2021-01-12 Thread kernel test robot
Hi Vincent, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.11-rc3 next-20210111] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in

Re: [PATCH v10 1/1] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces

2021-01-12 Thread Vincent MAILHOL
On Tue. 12 Jan 2021 at 22:05, Vincent Mailhol wrote: > > This driver supports the ES581.4, ES582.1 and ES584.1 interfaces from > ETAS GmbH (https://www.etas.com/en/products/es58x.php). > > Co-developed-by: Arunachalam Santhanam > Signed-off-by: Arunachalam Santhanam > Signed-off-by: Vincent Mail