Re: [PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread Paul Moore
On Tuesday 11 December 2007 12:21:26 pm David Miller wrote: > From: Paul Moore <[EMAIL PROTECTED]> > Date: Tue, 11 Dec 2007 12:15:00 -0500 > > > I still would like to see the rest of the changes make it into > > 2.6.25 (the SPI byte order thing is particularly troublesome) so if > > you don't mind

Re: [PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread Paul Moore
On Tuesday 11 December 2007 12:19:57 pm YOSHIFUJI Hideaki / 吉藤英明 wrote: > Please do not mangle tabs into spaces. Yes indeed. Not quite sure what happened there but I just fixed it. Thanks for pointing that out. -- paul moore linux security @ hp -- To unsubscribe from this list: send the line "

Re: [PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread David Miller
From: Paul Moore <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 12:15:00 -0500 > I still would like to see the rest of the changes make it into > 2.6.25 (the SPI byte order thing is particularly troublesome) so if > you don't mind a "v3" I'll respin this patch right now to remove the > "sid -> secid"

Re: [PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 11 Dec 2007 11:30:19 -0500), Paul Moore <[EMAIL PROTECTED]> says: > diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c > index 5b860b6..e2a3dd1 100644 > --- a/net/xfrm/xfrm_state.c > +++ b/net/xfrm/xfrm_state.c : > @@ -1994,67 +1995,59 @@ void __ini

Re: [PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread Paul Moore
On Tuesday 11 December 2007 12:06:11 pm David Miller wrote: > From: Paul Moore <[EMAIL PROTECTED]> > Date: Tue, 11 Dec 2007 11:30:19 -0500 > > Sorry for not pointing this out sooner: No problem, better late than never ... despite reports to the contrary, breaking userspace doesn't excite me as mu

Re: [PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread David Miller
From: Paul Moore <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 11:30:19 -0500 Sorry for not pointing this out sooner: > * Convert 'sid' to 'secid' >The 'sid' name is specific to SELinux, 'secid' is the common naming >convention used by the kernel when refering to tokenized LSM labels ... >

[PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread Paul Moore
This patch fixes a number of small but potentially troublesome things in the XFRM/IPsec code: * Use the 'audit_enabled' variable already in include/linux/audit.h Removed the need for extern declarations local to each XFRM audit fuction * Convert 'sid' to 'secid' The 'sid' name is specific