Re: [PATCH v2] isdn/gigaset: Convert timers to use timer_setup()

2017-10-09 Thread Kees Cook
On Mon, Oct 9, 2017 at 2:15 AM, David Laight wrote: > From: Kees Cook >> Sent: 06 October 2017 20:40 > ... >> I'm in no rush for any specific change. There are about 900 call sites >> I'm making my way through, about 2/3rd are pretty trivial, and the >> less obvious is

RE: [PATCH v2] isdn/gigaset: Convert timers to use timer_setup()

2017-10-09 Thread David Laight
From: Kees Cook > Sent: 06 October 2017 20:40 ... > I'm in no rush for any specific change. There are about 900 call sites > I'm making my way through, about 2/3rd are pretty trivial, and the > less obvious is what I've started sending out now, since I expect some > will need some more careful

Re: [PATCH v2] isdn/gigaset: Convert timers to use timer_setup()

2017-10-06 Thread Kees Cook
On Fri, Oct 6, 2017 at 12:00 PM, Paul Bolle wrote: > On Thu, 2017-10-05 at 12:31 -0700, Kees Cook wrote: >> --- a/drivers/isdn/gigaset/bas-gigaset.c >> +++ b/drivers/isdn/gigaset/bas-gigaset.c > >> -static void cmd_in_timeout(unsigned long data) >> +static void

Re: [PATCH v2] isdn/gigaset: Convert timers to use timer_setup()

2017-10-06 Thread Paul Bolle
On Thu, 2017-10-05 at 12:31 -0700, Kees Cook wrote: > --- a/drivers/isdn/gigaset/bas-gigaset.c > +++ b/drivers/isdn/gigaset/bas-gigaset.c > -static void cmd_in_timeout(unsigned long data) > +static void cmd_in_timeout(struct timer_list *t) > { > - struct cardstate *cs = (struct cardstate *)

[PATCH v2] isdn/gigaset: Convert timers to use timer_setup()

2017-10-05 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Paul Bolle Cc: Karsten Keil Cc: "David S. Miller"