Re: [PATCH v2] net/ncsi: Add NCSI OEM command support

2018-10-02 Thread Vijay Khemka
Hi Justin, Please see comments below -Vijay > > > diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c > > > index 7567ca63aae2..2f98533eba46 100644 > > > --- a/net/ncsi/ncsi-cmd.c > > > +++ b/net/ncsi/ncsi-cmd.c > > > @@ -211,6 +211,26 @@ static int ncsi_cmd_handler_snfc(s

RE: [PATCH v2] net/ncsi: Add NCSI OEM command support

2018-10-02 Thread Justin.Lee1
Hi Vijay, Please see the comments below. Thanks, Justin > Hi Justin, > Thanks for response. Please see my comments below. > > -Vijay > > > > diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c > > > index 7567ca63aae2..2f98533eba46 100644 > > > --- a/net/ncsi/ncsi-cmd.c > > > +++ b/net

Re: [PATCH v2] net/ncsi: Add NCSI OEM command support

2018-10-02 Thread Vijay Khemka
Hi Justin, Thanks for response. Please see my comments below. -Vijay > > diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c > > index 7567ca63aae2..2f98533eba46 100644 > > --- a/net/ncsi/ncsi-cmd.c > > +++ b/net/ncsi/ncsi-cmd.c > > @@ -211,6 +211,26 @@ static int ncsi_cmd_h

RE: [PATCH v2] net/ncsi: Add NCSI OEM command support

2018-10-02 Thread Justin.Lee1
Hi Vijay, Looks good. Please see my comment below. Thanks, Justin > On Fri, 2018-09-28 at 18:06 -0700, Vijay Khemka wrote: > > This patch adds OEM commands and response handling. It also defines OEM > > command and response structure as per NCSI specification along with its > > handlers. > > >

Re: [PATCH v2] net/ncsi: Add NCSI OEM command support

2018-10-01 Thread Samuel Mendoza-Jonas
On Fri, 2018-09-28 at 18:06 -0700, Vijay Khemka wrote: > This patch adds OEM commands and response handling. It also defines OEM > command and response structure as per NCSI specification along with its > handlers. > > ncsi_cmd_handler_oem: This is a generic command request handler for OEM > comma

Re: [Potential Spoof] Re: [PATCH v2] net/ncsi: Add NCSI OEM command support

2018-10-01 Thread Vijay Khemka
On 9/28/18, 6:21 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: > On 9/28/18, 6:07 PM, "Vijay Khemka" wrote: > This patch adds OEM commands and response handling. It also defines OEM > command and response structure as per NCSI specification along with i

Re: [PATCH v2] net/ncsi: Add NCSI OEM command support

2018-09-28 Thread Vijay Khemka
> On 9/28/18, 6:07 PM, "Vijay Khemka" wrote: > This patch adds OEM commands and response handling. It also defines OEM > command and response structure as per NCSI specification along with its > handlers. > > ncsi_cmd_handler_oem: This is a generic command request handler for O

[PATCH v2] net/ncsi: Add NCSI OEM command support

2018-09-28 Thread Vijay Khemka
This patch adds OEM commands and response handling. It also defines OEM command and response structure as per NCSI specification along with its handlers. ncsi_cmd_handler_oem: This is a generic command request handler for OEM commands ncsi_rsp_handler_oem: This is a generic response handler for OE