Re: [PATCH v2] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed

2016-11-16 Thread David Miller
From: Alexandru Gagniuc Date: Wed, 16 Nov 2016 01:02:33 -0800 > With RGMII, we need a 1.5 to 2ns skew between clock and data lines. The > VSC8601 can handle this internally. While the VSC8601 can set more > fine-grained delays, the standard skew settings work out of the box. > The same heuristic

Re: [PATCH v2] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed

2016-11-16 Thread Alex
On 11/16/2016 08:54 AM, Andrew Lunn wrote: On Wed, Nov 16, 2016 at 08:44:30AM -0800, Alex wrote: On 11/16/2016 05:50 AM, Andrew Lunn wrote: On Wed, Nov 16, 2016 at 01:02:33AM -0800, Alexandru Gagniuc wrote: With RGMII, we need a 1.5 to 2ns skew between clock and data lines. The VSC8601 can

Re: [PATCH v2] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed

2016-11-16 Thread Andrew Lunn
On Wed, Nov 16, 2016 at 08:44:30AM -0800, Alex wrote: > > > On 11/16/2016 05:50 AM, Andrew Lunn wrote: > >On Wed, Nov 16, 2016 at 01:02:33AM -0800, Alexandru Gagniuc wrote: > >>With RGMII, we need a 1.5 to 2ns skew between clock and data lines. The > >>VSC8601 can handle this internally. While th

Re: [PATCH v2] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed

2016-11-16 Thread Alex
On 11/16/2016 05:50 AM, Andrew Lunn wrote: On Wed, Nov 16, 2016 at 01:02:33AM -0800, Alexandru Gagniuc wrote: With RGMII, we need a 1.5 to 2ns skew between clock and data lines. The VSC8601 can handle this internally. While the VSC8601 can set more fine-grained delays, the standard skew settin

Re: [PATCH v2] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed

2016-11-16 Thread Andrew Lunn
On Wed, Nov 16, 2016 at 01:02:33AM -0800, Alexandru Gagniuc wrote: > With RGMII, we need a 1.5 to 2ns skew between clock and data lines. The > VSC8601 can handle this internally. While the VSC8601 can set more > fine-grained delays, the standard skew settings work out of the box. > The same heurist

[PATCH v2] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed

2016-11-16 Thread Alexandru Gagniuc
With RGMII, we need a 1.5 to 2ns skew between clock and data lines. The VSC8601 can handle this internally. While the VSC8601 can set more fine-grained delays, the standard skew settings work out of the box. The same heuristic is used to determine when this skew should be enabled as in vsc824x_conf