Re: [Outreachy kernel] Re: [PATCH v2] net: ethernet: Drop unnecessary continue

On Wed, 7 Mar 2018, Arushi Singhal wrote: > > > On Wed, Mar 7, 2018 at 9:09 PM, David Miller wrote: > From: Arushi Singhal > Date: Sat, 3 Mar 2018 21:44:56 +0530 > > > Continue at the bottom of a loop are removed. >

Re: [PATCH v2] net: ethernet: Drop unnecessary continue

From: Arushi Singhal Date: Wed, 7 Mar 2018 22:22:13 +0530 > Yes I know it's for the inner loop. > But I am not able to find, where I am wrong here You are making what is essentially a nop change to a piece of code, which if you had instead read carefully would

Re: [PATCH v2] net: ethernet: Drop unnecessary continue

From: Arushi Singhal Date: Sat, 3 Mar 2018 21:44:56 +0530 > Continue at the bottom of a loop are removed. > Issue found using drop_continue.cocci Coccinelle script. > > Signed-off-by: Arushi Singhal > --- > Changes in v2: > -

Re: [PATCH v2] net: ethernet: Drop unnecessary continue

On Sat, 3 Mar 2018 21:44:56 +0530, Arushi Singhal wrote: > diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_main.c > b/drivers/net/ethernet/netronome/nfp/nfp_net_main.c > index 15fa47f..5cd4f3f 100644 > --- a/drivers/net/ethernet/netronome/nfp/nfp_net_main.c > +++

[PATCH v2] net: ethernet: Drop unnecessary continue

Continue at the bottom of a loop are removed. Issue found using drop_continue.cocci Coccinelle script. Signed-off-by: Arushi Singhal --- Changes in v2: - Braces is dropped from if with single statement. drivers/net/ethernet/amd/ni65.c | 4 +---