Re: [PATCH v2] nohz: prevent tilegx network driver interrupts

2015-07-11 Thread Chris Metcalf
On Jul 11, 2015, at 10:44 AM, Frederic Weisbecker fweis...@gmail.com wrote: On Fri, Jul 10, 2015 at 03:37:25PM -0400, Chris Metcalf wrote: Normally the tilegx networking shim sends irqs to all the cores to distribute the load of processing incoming-packet interrupts, so that you can get to

Re: [PATCH v2] nohz: prevent tilegx network driver interrupts

2015-07-11 Thread Frederic Weisbecker
On Fri, Jul 10, 2015 at 03:37:25PM -0400, Chris Metcalf wrote: Normally the tilegx networking shim sends irqs to all the cores to distribute the load of processing incoming-packet interrupts, so that you can get to multiple Gb's of traffic inbound. However, in nohz_full mode we don't want to

Re: [PATCH v2] nohz: prevent tilegx network driver interrupts

2015-07-10 Thread Chris Metcalf
On 7/10/2015 6:45 PM, Josh Cartwright wrote: +static inline const struct cpumask *housekeeping_cpumask(void) +{ +#ifdef CONFIG_NO_HZ_FULL + if (tick_nohz_full_enabled()) + return housekeeping_mask; +#endif Just a small comment: We can take these checks out from under a #ifdef

Re: [PATCH v2] nohz: prevent tilegx network driver interrupts

2015-07-10 Thread Josh Cartwright
On Fri, Jul 10, 2015 at 07:06:23PM -0400, Chris Metcalf wrote: On 7/10/2015 6:45 PM, Josh Cartwright wrote: +static inline const struct cpumask *housekeeping_cpumask(void) +{ +#ifdef CONFIG_NO_HZ_FULL + if (tick_nohz_full_enabled()) + return housekeeping_mask; +#endif Just a