[PATCH v2] packet: uses kfree_skb() for drops or errors.

2016-04-06 Thread Weongyo Jeong
consume_skb() isn't for drop or error cases that kfree_skb() is more proper one. At this patch, it fixed tpacket_rcv() and packet_rcv() to be consistent for error or non-error cases letting perf trace its event properly. Signed-off-by: Weongyo Jeong --- net/packet/af_packet.c | 16

Re: [PATCH v2] packet: uses kfree_skb() for drops or errors.

2016-04-07 Thread Willem de Bruijn
On Wed, Apr 6, 2016 at 5:14 PM, Weongyo Jeong wrote: > consume_skb() isn't for drop or error cases for drop or error -> for error > that kfree_skb() is more proper > one. At this patch, it fixed tpacket_rcv() and packet_rcv() to be > consistent for error or non-error cases letting perf trace i

Re: [PATCH v2] packet: uses kfree_skb() for drops or errors.

2016-04-08 Thread Weongyo Jeong
On Thu, Apr 07, 2016 at 12:06:12PM -0400, Willem de Bruijn wrote: > On Wed, Apr 6, 2016 at 5:14 PM, Weongyo Jeong wrote: > > consume_skb() isn't for drop or error cases > > for drop or error -> for error > > > that kfree_skb() is more proper > > one. At this patch, it fixed tpacket_rcv() and p