Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2017-07-17 Thread Rob Herring
On Fri, Jul 14, 2017 at 01:48:45PM -0700, Moritz Fischer wrote: > This adds bindings for the NI XGE 1G/10G network device. > > Signed-off-by: Moritz Fischer > --- > Documentation/devicetree/bindings/net/nixge.txt | 32 > + > 1 file changed, 32 insertions(+) > create mod

Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2017-07-17 Thread Moritz Fischer
On Sat, Jul 15, 2017 at 09:48:32PM +0200, Andrew Lunn wrote: > > > > + ethernet_phy1: ethernet-phy@4 { > > > > + compatible = "ethernet-phy-ieee802.3-c45"; > > > > + reg = <4>; > > > > + devices = <0xa>; > > > > +

Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2017-07-15 Thread Andrew Lunn
> > > + ethernet_phy1: ethernet-phy@4 { > > > + compatible = "ethernet-phy-ieee802.3-c45"; > > > + reg = <4>; > > > + devices = <0xa>; > > > + }; > > > > Since you don't fully implement c45, does this example actually work? > > Yeah,

Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2017-07-15 Thread Moritz Fischer
Hi Andrew, On Sat, Jul 15, 2017 at 08:37:45PM +0200, Andrew Lunn wrote: > On Fri, Jul 14, 2017 at 01:48:45PM -0700, Moritz Fischer wrote: > > This adds bindings for the NI XGE 1G/10G network device. > > > > Signed-off-by: Moritz Fischer > > --- > > Documentation/devicetree/bindings/net/nixge.tx

Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2017-07-15 Thread Andrew Lunn
On Fri, Jul 14, 2017 at 01:48:45PM -0700, Moritz Fischer wrote: > This adds bindings for the NI XGE 1G/10G network device. > > Signed-off-by: Moritz Fischer > --- > Documentation/devicetree/bindings/net/nixge.txt | 32 > + > 1 file changed, 32 insertions(+) > create mod

[PATCH v2 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2017-07-14 Thread Moritz Fischer
This adds bindings for the NI XGE 1G/10G network device. Signed-off-by: Moritz Fischer --- Documentation/devicetree/bindings/net/nixge.txt | 32 + 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/nixge.txt diff --git a/Documentat