On Sat, Dec 16, 2017 at 06:11:01PM +0100, Heiner Kallweit wrote:
> Am 21.11.2017 um 02:34 schrieb Andrew Lunn:
> > Hi Heiner
> >
> > Do you have access to the data sheet?
> >
> > I had a quick look through the driver. It would be nice to refactor it
> > to follow the usual Linux conventions:
> >
Am 21.11.2017 um 02:34 schrieb Andrew Lunn:
> Hi Heiner
>
> Do you have access to the data sheet?
>
> I had a quick look through the driver. It would be nice to refactor it
> to follow the usual Linux conventions:
>
> Turn the MDIO read/write functions into an MDIO bus driver.
>
> Move the PHY
Am 21.11.2017 um 02:34 schrieb Andrew Lunn:
> Hi Heiner
Hi Andrew,
>
> Do you have access to the data sheet?
>
Not to more recent ones. I only have two older data sheets for early
members of the rtl8169 family.
> I had a quick look through the driver. It would be nice to refactor it
> to follow
Hi Heiner
Do you have access to the data sheet?
I had a quick look through the driver. It would be nice to refactor it
to follow the usual Linux conventions:
Turn the MDIO read/write functions into an MDIO bus driver.
Move the PHY code into drivers/net/phy/realtek.c, and in the process,
replace
From: Heiner Kallweit
Date: Sun, 19 Nov 2017 11:09:58 +0100
> Name of functions rtl_w0w1_eri and rtl_w0w1_phy is somewhat misleading
> regarding order of arguments. One could assume that w0w1 means
> argument with bits to be reset comes before argument with bits to set.
> However this is not the
Name of functions rtl_w0w1_eri and rtl_w0w1_phy is somewhat misleading
regarding order of arguments. One could assume that w0w1 means
argument with bits to be reset comes before argument with bits to set.
However this is not the case.
So fix the order of arguments in several statements.
In additio
