Re: [PATCH v2 1/2] sctp: compress bit-wide flags to a bitfield on sctp_sock

2016-04-06 Thread marcelo . leitner
On Wed, Apr 06, 2016 at 03:57:35PM -0400, David Miller wrote: > From: Joe Perches > Date: Wed, 06 Apr 2016 12:53:24 -0700 > > > On Wed, 2016-04-06 at 14:53 -0300, Marcelo Ricardo Leitner wrote: > >> It wastes space and gets worse as we add new flags, so convert bit-wide > >>

Re: [PATCH v2 1/2] sctp: compress bit-wide flags to a bitfield on sctp_sock

2016-04-06 Thread David Miller
From: Joe Perches Date: Wed, 06 Apr 2016 12:53:24 -0700 > On Wed, 2016-04-06 at 14:53 -0300, Marcelo Ricardo Leitner wrote: >> It wastes space and gets worse as we add new flags, so convert bit-wide >> flags to a bitfield. >> >> Currently it already saves 4 bytes in sctp_sock,

Re: [PATCH v2 1/2] sctp: compress bit-wide flags to a bitfield on sctp_sock

2016-04-06 Thread Joe Perches
On Wed, 2016-04-06 at 14:53 -0300, Marcelo Ricardo Leitner wrote: > It wastes space and gets worse as we add new flags, so convert bit-wide > flags to a bitfield. > > Currently it already saves 4 bytes in sctp_sock, which are left as holes > in it for now. The whole struct needs packing, which

[PATCH v2 1/2] sctp: compress bit-wide flags to a bitfield on sctp_sock

2016-04-06 Thread Marcelo Ricardo Leitner
It wastes space and gets worse as we add new flags, so convert bit-wide flags to a bitfield. Currently it already saves 4 bytes in sctp_sock, which are left as holes in it for now. The whole struct needs packing, which should be done in another patch. Note that do_auto_asconf cannot be merged,