Re: [PATCH v2 1/3] net: core: ethtool: add ethtool_op_{get|set}_link_ksettings

Are you sure this belongs to ethtool.h? For one, I believe you need an #include phy.h somewhere. I would suggest instead to keep this in phy.h, presumably with a more explicit name suggesting that phydev is involved. On Sun, May 8, 2016 at 2:44 PM, Philippe Reynes wrote: >

[PATCH v2 1/3] net: core: ethtool: add ethtool_op_{get|set}_link_ksettings

Ethtool callbacks {get|set}_link_ksettings are often the same, so we add two generics functions ethtool_op_{get|set}_link_ksettings to avoid writing severals times the same function. Signed-off-by: Philippe Reynes --- include/linux/ethtool.h |5 + net/core/ethtool.c