Re: [PATCH v2 2/3] dt-binding: net: sfp binding documentation

2017-09-01 Thread Rob Herring
On Wed, Aug 30, 2017 at 04:58:29PM +0200, Andrew Lunn wrote: > > > > > Your example shows there's GPIO phandle *and* specifier. > > > > > > > > Would "GPIO specifier" be enough here? > > > > > >No, specifier is the cells following GPIO (or any other) phandle. > > > > So this should be

Re: [PATCH v2 2/3] dt-binding: net: sfp binding documentation

2017-08-30 Thread Andrew Lunn
> > > > Your example shows there's GPIO phandle *and* specifier. > > > > > > Would "GPIO specifier" be enough here? > > > >No, specifier is the cells following GPIO (or any other) phandle. > > So this should be "GPIO phandle and specifier of ...", is that correct? > > I have found very

Re: [PATCH v2 2/3] dt-binding: net: sfp binding documentation

2017-08-30 Thread Sergei Shtylyov
On 08/30/2017 02:25 PM, Baruch Siach wrote: Add device-tree binding documentation SFP transceivers. Support for SFP transceivers has been recently introduced (drivers/net/phy/sfp.c). Signed-off-by: Baruch Siach --- v2: Rename -gpio properties to -gpios Rename the

Re: [PATCH v2 2/3] dt-binding: net: sfp binding documentation

2017-08-30 Thread Baruch Siach
Hi Sergei, On Wed, Aug 30, 2017 at 02:15:32PM +0300, Sergei Shtylyov wrote: > On 8/30/2017 2:11 PM, Baruch Siach wrote: > > > On Wed, Aug 30, 2017 at 02:04:11PM +0300, Sergei Shtylyov wrote: > > > On 8/30/2017 12:51 PM, Baruch Siach wrote: > > > > > > > Add device-tree binding documentation SFP

Re: [PATCH v2 2/3] dt-binding: net: sfp binding documentation

2017-08-30 Thread Sergei Shtylyov
Hello! On 8/30/2017 12:51 PM, Baruch Siach wrote: Add device-tree binding documentation SFP transceivers. Support for SFP transceivers has been recently introduced (drivers/net/phy/sfp.c). Signed-off-by: Baruch Siach --- v2: Rename -gpio properties to -gpios Rename

[PATCH v2 2/3] dt-binding: net: sfp binding documentation

2017-08-30 Thread Baruch Siach
Add device-tree binding documentation SFP transceivers. Support for SFP transceivers has been recently introduced (drivers/net/phy/sfp.c). Signed-off-by: Baruch Siach --- v2: Rename -gpio properties to -gpios Rename the rate-select-gpio property to rate-select0-gpios Add