Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-08-01 Thread Kurt Van Dijck
> Hi Kurt, > > On 07/28/2017 09:41 PM, Kurt Van Dijck wrote: > > >>The transceiver is an analog device that needs to support faster > >>switching frequency (FETs) including minimizing delay to support CAN-FD > >>ie higher bitrate. From the transceiver perspective the bits for > >>"arbitration" an

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-31 Thread Oliver Hartkopp
Hi Kurt, On 07/28/2017 09:41 PM, Kurt Van Dijck wrote: The transceiver is an analog device that needs to support faster switching frequency (FETs) including minimizing delay to support CAN-FD ie higher bitrate. From the transceiver perspective the bits for "arbitration" and "data" look exactly

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-28 Thread Kurt Van Dijck
> > On 07/28/2017 01:33 PM, Oliver Hartkopp wrote: > > Hi Kurt, > > > > On 07/28/2017 03:02 PM, Kurt Van Dijck wrote: > > > The word 'max-arbitration-bitrate' makes the difference very clear. > >>> > >>> I think you are mixing up ISO layer 1 and ISO layer 2. > >> > >> In order to provide h

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-28 Thread Franklin S Cooper Jr
On 07/28/2017 01:33 PM, Oliver Hartkopp wrote: > Hi Kurt, > > On 07/28/2017 03:02 PM, Kurt Van Dijck wrote: > The word 'max-arbitration-bitrate' makes the difference very clear. >>> >>> I think you are mixing up ISO layer 1 and ISO layer 2. >> >> In order to provide higher data throughput

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-28 Thread Oliver Hartkopp
Hi Kurt, On 07/28/2017 03:02 PM, Kurt Van Dijck wrote: The word 'max-arbitration-bitrate' makes the difference very clear. I think you are mixing up ISO layer 1 and ISO layer 2. In order to provide higher data throughput without putting extra limits on transceiver & wire, the requirement fo

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-28 Thread Kurt Van Dijck
> > On 07/28/2017 06:57 AM, Kurt Van Dijck wrote: > > >So while _a_ transceiver may be spec'd to 1MBit during arbitration, > >CAN FD packets may IMHO exceed that speed during data phase. > > When the bitrate is limited to 1Mbit/s you are ONLY allowed to use 1Mbit/s > in the data section too (eit

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-28 Thread Oliver Hartkopp
On 07/28/2017 06:57 AM, Kurt Van Dijck wrote: So while _a_ transceiver may be spec'd to 1MBit during arbitration, CAN FD packets may IMHO exceed that speed during data phase. When the bitrate is limited to 1Mbit/s you are ONLY allowed to use 1Mbit/s in the data section too (either with CAN or

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-27 Thread Kurt Van Dijck
> > On 07/27/2017 01:47 PM, Oliver Hartkopp wrote: > > On 07/26/2017 08:29 PM, Franklin S Cooper Jr wrote: > >> > > > >> I'm fine with switching to using bitrate instead of speed. Kurk was > >> originally the one that suggested to use the term arbitration and data > >> since thats how the spec r

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-27 Thread Franklin S Cooper Jr
On 07/27/2017 01:47 PM, Oliver Hartkopp wrote: > On 07/26/2017 08:29 PM, Franklin S Cooper Jr wrote: >> > >> I'm fine with switching to using bitrate instead of speed. Kurk was >> originally the one that suggested to use the term arbitration and data >> since thats how the spec refers to it. Whi

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-27 Thread Oliver Hartkopp
On 07/26/2017 08:29 PM, Franklin S Cooper Jr wrote: I'm fine with switching to using bitrate instead of speed. Kurk was originally the one that suggested to use the term arbitration and data since thats how the spec refers to it. Which I do agree with. But your right that in the drivers (stru

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-26 Thread Franklin S Cooper Jr
On 07/26/2017 12:05 PM, Oliver Hartkopp wrote: > On 07/26/2017 06:41 PM, Andrew Lunn wrote: >> On Mon, Jul 24, 2017 at 06:05:19PM -0500, Franklin S Cooper Jr wrote: > >>> + >>> +Optional: >>> + max-arbitration-speed: a positive non 0 value that determines the max >>> +speed that CAN

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-26 Thread Oliver Hartkopp
On 07/26/2017 06:41 PM, Andrew Lunn wrote: On Mon, Jul 24, 2017 at 06:05:19PM -0500, Franklin S Cooper Jr wrote: + +Optional: + max-arbitration-speed: a positive non 0 value that determines the max + speed that CAN can run in non CAN-FD mode or during the +

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-26 Thread Andrew Lunn
On Mon, Jul 24, 2017 at 06:05:19PM -0500, Franklin S Cooper Jr wrote: > Add documentation to describe usage of the new fixed transceiver binding. > This new binding is applicable for any CAN device therefore it exists as > its own document. > > Signed-off-by: Franklin S Cooper Jr > --- > Version

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-25 Thread Franklin S Cooper Jr
On 07/25/2017 11:32 AM, Oliver Hartkopp wrote: > >> + max-data-speed:a positive non 0 value that determines the max >> data rate >> +that can be used in CAN-FD mode. A value of -1 implies >> +CAN-FD is not supported by the transceiver. >> + >> +Examples: > > (..) >

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-25 Thread Oliver Hartkopp
+ max-data-speed: a positive non 0 value that determines the max data rate + that can be used in CAN-FD mode. A value of -1 implies + CAN-FD is not supported by the transceiver. + +Examples: (..) + fixed-transceiver { + ma

[PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

2017-07-24 Thread Franklin S Cooper Jr
Add documentation to describe usage of the new fixed transceiver binding. This new binding is applicable for any CAN device therefore it exists as its own document. Signed-off-by: Franklin S Cooper Jr --- Version 2: Tweak commit message working Tweak wording for properties Drop unit addressing Gi