[PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-16 Thread Michael Schmitz
From: John Paul Adrian Glaubitz This complements the fix in 82533ad9a1c that removed the free_irq call in the error path of probe, to also not call free_irq when remove is called to revert the effects of probe. Signed-off-by: Michael Karcher --- drivers/net/ethernet/8390/ax88796.c |1 - 1

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-17 Thread Geert Uytterhoeven
Hi Michael, Adrian, Thanks for your patch! On Tue, Apr 17, 2018 at 4:08 AM, Michael Schmitz wrote: > From: John Paul Adrian Glaubitz > > This complements the fix in 82533ad9a1c that removed the free_irq Please quote the commit's subject, too, like ... fix in commit 82533ad9a1 ("net: ethernet:

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-17 Thread John Paul Adrian Glaubitz
On 04/17/2018 04:08 AM, Michael Schmitz wrote: From: John Paul Adrian Glaubitz This should be: From: Michael Karcher -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-17 Thread David Miller
From: Geert Uytterhoeven Date: Tue, 17 Apr 2018 10:20:25 +0200 > BTW, I have a git alias for that: > > $ git help fixes > `git fixes' is aliased to `show --format='Fixes: %h ("%s")' -s' > $ git fixes 82533ad9a1c > Fixes: 82533ad9a1c ("net: ethernet: ax88796: don't call free_irq > without request

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-17 Thread Michael Schmitz
Hi Adrian, On Tue, Apr 17, 2018 at 11:40 PM, John Paul Adrian Glaubitz wrote: > On 04/17/2018 04:08 AM, Michael Schmitz wrote: >> >> From: John Paul Adrian Glaubitz > > This should be: > > From: Michael Karcher I haven't found a way to change that in my tree yet, sorry. Unless someone has a si

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-17 Thread Michael Schmitz
Thanks Geert, I'll fix that. I see my v2 series shows up as new series on patchwork - do I need to do something different when tagging the next version, Dave? Cheers, Michael On Wed, Apr 18, 2018 at 1:51 AM, David Miller wrote: > From: Geert Uytterhoeven > Date: Tue, 17 Apr 2018 10:20:25 +

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-17 Thread John Paul Adrian Glaubitz
On 04/17/2018 10:32 PM, Michael Schmitz wrote: >> From: Michael Karcher > > I haven't found a way to change that in my tree yet, sorry. Unless > someone has a simple way to fix patch authorship after a merge, I may > have to reimport from scratch. I guess you'll have to re-import then, sorry :(.

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-17 Thread Andrew Lunn
On Wed, Apr 18, 2018 at 08:32:25AM +1200, Michael Schmitz wrote: > Hi Adrian, > > On Tue, Apr 17, 2018 at 11:40 PM, John Paul Adrian Glaubitz > wrote: > > On 04/17/2018 04:08 AM, Michael Schmitz wrote: > >> > >> From: John Paul Adrian Glaubitz > > > > This should be: > > > > From: Michael Karche

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-17 Thread Michael Schmitz
Hi Andrew, thanks, that's what I was looking for. The next version will have all but one patch correctly attributed to Michael Karcher. Cheers, Michael On Wed, Apr 18, 2018 at 9:13 AM, Andrew Lunn wrote: > On Wed, Apr 18, 2018 at 08:32:25AM +1200, Michael Schmitz wrote: >> Hi Adrian, >> >>