Re: [PATCH v2 4/4] net: make skb_gso_*_seglen functions private

2018-03-02 Thread Marcelo Ricardo Leitner
On Thu, Mar 01, 2018 at 05:13:40PM +1100, Daniel Axtens wrote: > They're very hard to use properly as they do not consider the > GSO_BY_FRAGS case. Code should use skb_gso_validate_network_len > and skb_gso_validate_mac_len as they do consider this case. > > Make the seglen functions static, which

[PATCH v2 4/4] net: make skb_gso_*_seglen functions private

2018-02-28 Thread Daniel Axtens
They're very hard to use properly as they do not consider the GSO_BY_FRAGS case. Code should use skb_gso_validate_network_len and skb_gso_validate_mac_len as they do consider this case. Make the seglen functions static, which stops people using them outside of skbuff.c Signed-off-by: Daniel Axten