Tom Tucker wrote:
On Thu, 2006-06-08 at 01:17 -0700, Andrew Morton wrote:
On Wed, 07 Jun 2006 15:06:55 -0500
Steve Wise <[EMAIL PROTECTED]> wrote:
+void c2_free(struct c2_alloc *alloc, u32 obj)
+{
+ spin_lock(&alloc->lock);
+ clear_bit(obj, alloc->table);
+ spin_unlock(&all
On Mon, 2006-06-12 at 11:05 -0500, Tom Tucker wrote:
> On Thu, 2006-06-08 at 01:17 -0700, Andrew Morton wrote:
> > On Wed, 07 Jun 2006 15:06:55 -0500
> > Steve Wise <[EMAIL PROTECTED]> wrote:
> >
> > >
> > > +void c2_free(struct c2_alloc *alloc, u32 obj)
> > > +{
> > > + spin_lock(&alloc->lock)
On Thu, 2006-06-08 at 01:17 -0700, Andrew Morton wrote:
> On Wed, 07 Jun 2006 15:06:55 -0500
> Steve Wise <[EMAIL PROTECTED]> wrote:
>
> >
> > +void c2_free(struct c2_alloc *alloc, u32 obj)
> > +{
> > + spin_lock(&alloc->lock);
> > + clear_bit(obj, alloc->table);
> > + spin_unlock(&alloc->l
On Wed, 07 Jun 2006 15:06:55 -0500
Steve Wise <[EMAIL PROTECTED]> wrote:
>
> +void c2_free(struct c2_alloc *alloc, u32 obj)
> +{
> + spin_lock(&alloc->lock);
> + clear_bit(obj, alloc->table);
> + spin_unlock(&alloc->lock);
> +}
The spinlock is unneeded here.
What does all the code
Review Changes:
- sizeof -> sizeof()
---
drivers/infiniband/hw/amso1100/c2_alloc.c | 256
drivers/infiniband/hw/amso1100/c2_mm.c| 378 +
2 files changed, 634 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/amso1100/c2_allo
