Re: [PATCH v2 bpf-next] net: veth: alloc skb in bulk for ndo_xdp_xmit

2021-02-01 Thread Jesper Dangaard Brouer
On Fri, 29 Jan 2021 22:49:27 +0100 Lorenzo Bianconi wrote: > On Jan 29, Lorenzo Bianconi wrote: > > On Jan 29, Jesper Dangaard Brouer wrote: > > > On Fri, 29 Jan 2021 17:02:16 +0100 > > > Jesper Dangaard Brouer wrote: > > > > > > > > + for (i = 0; i < n_skb; i++) { > > > > > +

Re: [PATCH v2 bpf-next] net: veth: alloc skb in bulk for ndo_xdp_xmit

2021-01-29 Thread Lorenzo Bianconi
On Jan 29, Lorenzo Bianconi wrote: > On Jan 29, Jesper Dangaard Brouer wrote: > > On Fri, 29 Jan 2021 17:02:16 +0100 > > Jesper Dangaard Brouer wrote: > > > > > > + for (i = 0; i < n_skb; i++) { > > > > + struct sk_buff *skb = skbs[i]; > > > > + > > > > + memset(

Re: [PATCH v2 bpf-next] net: veth: alloc skb in bulk for ndo_xdp_xmit

2021-01-29 Thread Lorenzo Bianconi
On Jan 29, Jesper Dangaard Brouer wrote: > On Fri, 29 Jan 2021 17:02:16 +0100 > Jesper Dangaard Brouer wrote: > > > > + for (i = 0; i < n_skb; i++) { > > > + struct sk_buff *skb = skbs[i]; > > > + > > > + memset(skb, 0, offsetof(struct sk_buff, tail)); > > > > It is very subtle

Re: [PATCH v2 bpf-next] net: veth: alloc skb in bulk for ndo_xdp_xmit

2021-01-29 Thread Lorenzo Bianconi
> On 2021/01/29 4:41, Lorenzo Bianconi wrote: > > Split ndo_xdp_xmit and ndo_start_xmit use cases in veth_xdp_rcv routine > > in order to alloc skbs in bulk for XDP_PASS verdict. > > Introduce xdp_alloc_skb_bulk utility routine to alloc skb bulk list. > > The proposed approach has been tested in th

Re: [PATCH v2 bpf-next] net: veth: alloc skb in bulk for ndo_xdp_xmit

2021-01-29 Thread Jesper Dangaard Brouer
On Fri, 29 Jan 2021 17:02:16 +0100 Jesper Dangaard Brouer wrote: > > + for (i = 0; i < n_skb; i++) { > > + struct sk_buff *skb = skbs[i]; > > + > > + memset(skb, 0, offsetof(struct sk_buff, tail)); > > It is very subtle, but the memset operation on Intel CPU translates >