Re: [PATCH v2 net-next] net: remove bypassed check in sch_direct_xmit()

2018-05-31 Thread David Miller
From: Song Liu Date: Tue, 29 May 2018 10:03:21 -0700 > Checking netif_xmit_frozen_or_stopped() at the end of sch_direct_xmit() > is being bypassed. This is because "ret" from sch_direct_xmit() will be > either NETDEV_TX_OK or NETDEV_TX_BUSY, and only ret == NETDEV_TX_OK == 0 > will reach the cond

[PATCH v2 net-next] net: remove bypassed check in sch_direct_xmit()

2018-05-29 Thread Song Liu
Checking netif_xmit_frozen_or_stopped() at the end of sch_direct_xmit() is being bypassed. This is because "ret" from sch_direct_xmit() will be either NETDEV_TX_OK or NETDEV_TX_BUSY, and only ret == NETDEV_TX_OK == 0 will reach the condition: if (ret && netif_xmit_frozen_or_stopped(txq))