Re: [PATCH v2 net-next] tcp: add tracepoint trace_tcp_retransmit_synack()

2017-11-02 Thread David Miller
From: Song Liu Date: Mon, 30 Oct 2017 14:41:35 -0700 > This tracepoint can be used to trace synack retransmits. It maintains > pointer to struct request_sock. > > We cannot simply reuse trace_tcp_retransmit_skb() here, because the > sk here is the LISTEN socket. The IP addresses and ports should

Re: [PATCH v2 net-next] tcp: add tracepoint trace_tcp_retransmit_synack()

2017-10-30 Thread Eric Dumazet
On Mon, 2017-10-30 at 21:43 +, Song Liu wrote: > CCing key audience of the patch. > Please stop doing this for every patch you are sending. Include all relevant CC to your patch submission, and that's enough. Thanks.

Re: [PATCH v2 net-next] tcp: add tracepoint trace_tcp_retransmit_synack()

2017-10-30 Thread Song Liu
CCing key audience of the patch. Thanks, Song > On Oct 30, 2017, at 2:41 PM, Song Liu wrote: > > This tracepoint can be used to trace synack retransmits. It maintains > pointer to struct request_sock. > > We cannot simply reuse trace_tcp_retransmit_skb() here, because the > sk here is the LIST

[PATCH v2 net-next] tcp: add tracepoint trace_tcp_retransmit_synack()

2017-10-30 Thread Song Liu
This tracepoint can be used to trace synack retransmits. It maintains pointer to struct request_sock. We cannot simply reuse trace_tcp_retransmit_skb() here, because the sk here is the LISTEN socket. The IP addresses and ports should be extracted from struct request_sock. Note that, like many oth

[PATCH v2 net-next] tcp: add tracepoint trace_tcp_retransmit_synack

2017-10-30 Thread Song Liu
Change from v1: Updated commit message to highlight potential sparse warning. Song Liu (1): tcp: add tracepoint trace_tcp_retransmit_synack() include/trace/events/tcp.h | 56 ++ net/ipv4/tcp_output.c | 1 + 2 files changed, 57 insertions(+) --