Re: [PATCH v2 net-next 0/2] net/sched: support tunnel options in cls_flower and act_tunnel_key

2017-10-05 Thread Jiri Benc
On Mon, 2 Oct 2017 09:50:15 +0200, Simon Horman wrote: > I believe that in order to avoid per-packet overhead and at the same time > code complexity the TLVs should be described in-order. So matching on > TLV-A,TLV-B,TLV-C would be a different match to TLV-C,TLV-A,TLV-B. An > order-independent

Re: [PATCH v2 net-next 0/2] net/sched: support tunnel options in cls_flower and act_tunnel_key

2017-10-02 Thread Simon Horman
On Fri, Sep 29, 2017 at 05:54:23AM +0100, David Miller wrote: > From: Simon Horman > Date: Wed, 27 Sep 2017 10:16:32 +0200 > > > Users of options: > > > > * There are eBPF hooks to allow getting on and setting tunnel metadata: > > bpf_skb_set_tunnel_opt,

Re: [PATCH v2 net-next 0/2] net/sched: support tunnel options in cls_flower and act_tunnel_key

2017-09-29 Thread David Miller
From: Simon Horman Date: Wed, 27 Sep 2017 10:16:32 +0200 > Users of options: > > * There are eBPF hooks to allow getting on and setting tunnel metadata: > bpf_skb_set_tunnel_opt, bpf_skb_get_tunnel_opt. > > * Open vSwitch is able to match and set Geneve and

Re: [PATCH v2 net-next 0/2] net/sched: support tunnel options in cls_flower and act_tunnel_key

2017-09-27 Thread Jiri Benc
On Wed, 27 Sep 2017 10:16:32 +0200, Simon Horman wrote: > * Geneve > > In the case of Geneve options are TLVs[1]. My reading is that in collect > metadata mode the kernel does not appear to do anything other than pass > them around as a bytestring. > > [1]

[PATCH v2 net-next 0/2] net/sched: support tunnel options in cls_flower and act_tunnel_key

2017-09-27 Thread Simon Horman
Allow the flower classifier to match on tunnel options and the tunnel key action to set them. Tunnel options are a bytestring of up to 256 bytes. The flower classifier matching with an optional bitwise mask. Tunnel implementations may support more or less options, or none at all. Discussion