Re: [PATCH v2 net-next 0/2] net: phy: remove phy_error from phy_disable_interrupts

2018-03-07 Thread David Miller
From: Heiner Kallweit Date: Mon, 5 Mar 2018 22:29:43 +0100 > All callers of phy_disable_interrupts() call phy_error() in the error > case. Therefore we don't need to do this within the function too. > This change also allows us to use phy_disable_interrupts() in code >

[PATCH v2 net-next 0/2] net: phy: remove phy_error from phy_disable_interrupts

2018-03-05 Thread Heiner Kallweit
All callers of phy_disable_interrupts() call phy_error() in the error case. Therefore we don't need to do this within the function too. This change also allows us to use phy_disable_interrupts() in code holding phydev->lock (because phy_error() takes this lock). Make use of this in phy_stop().