Re: [PATCH v2 net-next 1/2] bpf/verifier: improve disassembly of BPF_END instructions

2017-09-26 Thread Daniel Borkmann
On 09/26/2017 05:35 PM, Edward Cree wrote: print_bpf_insn() was treating all BPF_ALU[64] the same, but BPF_END has a different structure: it has a size in insn->imm (even if it's BPF_X) and uses the BPF_SRC (X or K) to indicate which endianness to use. So it needs different code to print i

Re: [PATCH v2 net-next 1/2] bpf/verifier: improve disassembly of BPF_END instructions

2017-09-26 Thread Alexei Starovoitov
On Tue, Sep 26, 2017 at 04:35:13PM +0100, Edward Cree wrote: > print_bpf_insn() was treating all BPF_ALU[64] the same, but BPF_END has a > different structure: it has a size in insn->imm (even if it's BPF_X) and > uses the BPF_SRC (X or K) to indicate which endianness to use. So it > needs diff

[PATCH v2 net-next 1/2] bpf/verifier: improve disassembly of BPF_END instructions

2017-09-26 Thread Edward Cree
print_bpf_insn() was treating all BPF_ALU[64] the same, but BPF_END has a different structure: it has a size in insn->imm (even if it's BPF_X) and uses the BPF_SRC (X or K) to indicate which endianness to use. So it needs different code to print it. Signed-off-by: Edward Cree --- kernel/bpf/