Re: [PATCH v2 net-next 1/2] flow dissector: ICMP support

2016-12-06 Thread Simon Horman
On Tue, Dec 06, 2016 at 01:26:34PM +0100, Jiri Pirko wrote: > Tue, Dec 06, 2016 at 11:51:46AM CET, simon.hor...@netronome.com wrote: > >On Mon, Dec 05, 2016 at 09:29:45AM -0800, Tom Herbert wrote: > >> On Mon, Dec 5, 2016 at 6:23 AM, Simon Horman > >> wrote: > >> > On Sat, Dec 03, 2016 at 10:52:3

Re: [PATCH v2 net-next 1/2] flow dissector: ICMP support

2016-12-06 Thread Jiri Pirko
Tue, Dec 06, 2016 at 11:51:46AM CET, simon.hor...@netronome.com wrote: >On Mon, Dec 05, 2016 at 09:29:45AM -0800, Tom Herbert wrote: >> On Mon, Dec 5, 2016 at 6:23 AM, Simon Horman >> wrote: >> > On Sat, Dec 03, 2016 at 10:52:32AM -0800, Tom Herbert wrote: >> >> On Sat, Dec 3, 2016 at 2:49 AM, Ji

Re: [PATCH v2 net-next 1/2] flow dissector: ICMP support

2016-12-06 Thread Simon Horman
On Mon, Dec 05, 2016 at 09:29:45AM -0800, Tom Herbert wrote: > On Mon, Dec 5, 2016 at 6:23 AM, Simon Horman > wrote: > > On Sat, Dec 03, 2016 at 10:52:32AM -0800, Tom Herbert wrote: > >> On Sat, Dec 3, 2016 at 2:49 AM, Jiri Pirko wrote: > >> > Fri, Dec 02, 2016 at 09:31:41PM CET, simon.hor...@ne

Re: [PATCH v2 net-next 1/2] flow dissector: ICMP support

2016-12-05 Thread Tom Herbert
On Mon, Dec 5, 2016 at 6:23 AM, Simon Horman wrote: > On Sat, Dec 03, 2016 at 10:52:32AM -0800, Tom Herbert wrote: >> On Sat, Dec 3, 2016 at 2:49 AM, Jiri Pirko wrote: >> > Fri, Dec 02, 2016 at 09:31:41PM CET, simon.hor...@netronome.com wrote: >> >>Allow dissection of ICMP(V6) type and code. This

Re: [PATCH v2 net-next 1/2] flow dissector: ICMP support

2016-12-05 Thread Jiri Pirko
Mon, Dec 05, 2016 at 03:23:16PM CET, simon.hor...@netronome.com wrote: >On Sat, Dec 03, 2016 at 10:52:32AM -0800, Tom Herbert wrote: >> On Sat, Dec 3, 2016 at 2:49 AM, Jiri Pirko wrote: >> > Fri, Dec 02, 2016 at 09:31:41PM CET, simon.hor...@netronome.com wrote: >> >>Allow dissection of ICMP(V6) ty

Re: [PATCH v2 net-next 1/2] flow dissector: ICMP support

2016-12-05 Thread Simon Horman
On Sat, Dec 03, 2016 at 10:52:32AM -0800, Tom Herbert wrote: > On Sat, Dec 3, 2016 at 2:49 AM, Jiri Pirko wrote: > > Fri, Dec 02, 2016 at 09:31:41PM CET, simon.hor...@netronome.com wrote: > >>Allow dissection of ICMP(V6) type and code. This re-uses transport layer > >>port dissection code as altho

Re: [PATCH v2 net-next 1/2] flow dissector: ICMP support

2016-12-03 Thread Tom Herbert
On Sat, Dec 3, 2016 at 2:49 AM, Jiri Pirko wrote: > Fri, Dec 02, 2016 at 09:31:41PM CET, simon.hor...@netronome.com wrote: >>Allow dissection of ICMP(V6) type and code. This re-uses transport layer >>port dissection code as although ICMP is not a transport protocol and their >>type and code are no

Re: [PATCH v2 net-next 1/2] flow dissector: ICMP support

2016-12-03 Thread Jiri Pirko
Fri, Dec 02, 2016 at 09:31:41PM CET, simon.hor...@netronome.com wrote: >Allow dissection of ICMP(V6) type and code. This re-uses transport layer >port dissection code as although ICMP is not a transport protocol and their >type and code are not ports this allows sharing of both code and storage. >

[PATCH v2 net-next 1/2] flow dissector: ICMP support

2016-12-02 Thread Simon Horman
Allow dissection of ICMP(V6) type and code. This re-uses transport layer port dissection code as although ICMP is not a transport protocol and their type and code are not ports this allows sharing of both code and storage. Signed-off-by: Simon Horman --- drivers/net/bonding/bond_main.c | 6 +++-