Re: [PATCH v2 net-next 1/2] net: phy: remove phy_error from phy_disable_interrupts

2018-03-06 Thread Andrew Lunn
On Mon, Mar 05, 2018 at 10:34:27PM +0100, Heiner Kallweit wrote: > All callers of phy_disable_interrupts() call phy_error() in the error > case. Therefore we don't need to do this within the function too. > This change also allows us to use phy_disable_interrupts() in code > holding phydev->lock

[PATCH v2 net-next 1/2] net: phy: remove phy_error from phy_disable_interrupts

2018-03-05 Thread Heiner Kallweit
All callers of phy_disable_interrupts() call phy_error() in the error case. Therefore we don't need to do this within the function too. This change also allows us to use phy_disable_interrupts() in code holding phydev->lock (because phy_error() can take this lock). Signed-off-by: Heiner Kallweit