Re: [PATCH v2 net 0/3] net: bql: better deal with GSO

2018-11-06 Thread David Miller
From: Edward Cree Date: Tue, 6 Nov 2018 18:23:42 + > I'm doing a patch to update sfc to use this new helper.  Is this 'net' >  material, or should I wait for 'net-next' to open back up? As the driver maintainer I guess I can lead that judgment up to you at least to a certain extent.

Re: [PATCH v2 net 0/3] net: bql: better deal with GSO

2018-11-06 Thread Edward Cree
On 03/11/18 22:40, David Miller wrote: > Series applied, but I wonder how many other commonly used drivers we > should update the same way mlx4 is here? Hi David, I'm doing a patch to update sfc to use this new helper.  Is this 'net'  material, or should I wait for 'net-next' to open back up? -E

Re: [PATCH v2 net 0/3] net: bql: better deal with GSO

2018-11-03 Thread David Miller
From: Eric Dumazet Date: Sat, 3 Nov 2018 16:00:39 -0700 > On Sat, Nov 3, 2018 at 3:40 PM David Miller wrote: > >> Series applied, but I wonder how many other commonly used drivers we >> should update the same way mlx4 is here? > > I can provide patches but can not test them, so probably we sho

Re: [PATCH v2 net 0/3] net: bql: better deal with GSO

2018-11-03 Thread Eric Dumazet
On Sat, Nov 3, 2018 at 3:40 PM David Miller wrote: > Series applied, but I wonder how many other commonly used drivers we > should update the same way mlx4 is here? I can provide patches but can not test them, so probably we should get Tested-by tags before applying them. Thanks.

Re: [PATCH v2 net 0/3] net: bql: better deal with GSO

2018-11-03 Thread David Miller
From: Eric Dumazet Date: Wed, 31 Oct 2018 08:39:11 -0700 > While BQL bulk dequeue works well for TSO packets, it is > not very efficient as soon as GSO is involved. > > On a GSO only workload (UDP or TCP), this patch series > can save about 8 % of cpu cycles on a 40Gbit mlx4 NIC, > by keeping op

[PATCH v2 net 0/3] net: bql: better deal with GSO

2018-10-31 Thread Eric Dumazet
While BQL bulk dequeue works well for TSO packets, it is not very efficient as soon as GSO is involved. On a GSO only workload (UDP or TCP), this patch series can save about 8 % of cpu cycles on a 40Gbit mlx4 NIC, by keeping optimal batching, and avoiding expensive doorbells, qdisc requeues and re