Re: [PATCH v3] net: sched: crash on blocks with goto chain action

2017-12-06 Thread Cong Wang
On Tue, Dec 5, 2017 at 8:22 AM, David Miller wrote: > > This doesn't apply cleanly to 'net'. Dave, you already applied v2: commit a60b3f515d30d0fe8537c64671926879a3548103 Author: Roman Kapl Date: Fri Nov 24 12:27:58 2017 +0100 net: sched: crash on blocks with goto chain action And the d

Re: [PATCH v3] net: sched: crash on blocks with goto chain action

2017-12-05 Thread David Miller
From: Roman Kapl Date: Wed, 29 Nov 2017 20:20:14 +0100 > tcf_block_put_ext has assumed that all filters (and thus their goto > actions) are destroyed in RCU callback and so can not race with our > list iteration. However, that is not true during netns cleanup (see > tcf_exts_get_net comment). The

[PATCH v3] net: sched: crash on blocks with goto chain action

2017-11-29 Thread Roman Kapl
tcf_block_put_ext has assumed that all filters (and thus their goto actions) are destroyed in RCU callback and so can not race with our list iteration. However, that is not true during netns cleanup (see tcf_exts_get_net comment). The assumption was broken by the patch series c7e460ce5572..623859ae