Re: [PATCH v3 1/2] net: create skb_gso_validate_mac_len()

2018-01-30 Thread kbuild test robot
Hi Daniel, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] [also build test ERROR on v4.15 next-20180126] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/co

Re: [PATCH v3 1/2] net: create skb_gso_validate_mac_len()

2018-01-30 Thread kbuild test robot
Hi Daniel, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] [also build test ERROR on v4.15 next-20180126] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/co

Re: [PATCH v3 1/2] net: create skb_gso_validate_mac_len()

2018-01-30 Thread Daniel Axtens
Marcelo Ricardo Leitner writes: > Hi, > > On Tue, Jan 30, 2018 at 12:14:46PM +1100, Daniel Axtens wrote: >> If you take a GSO skb, and split it into packets, will the MAC >> length (L2 + L3 + L4 headers + payload) of those packets be small >> enough to fit within a given length? >> >> Move skb_g

Re: [PATCH v3 1/2] net: create skb_gso_validate_mac_len()

2018-01-30 Thread Marcelo Ricardo Leitner
Hi, On Tue, Jan 30, 2018 at 12:14:46PM +1100, Daniel Axtens wrote: > If you take a GSO skb, and split it into packets, will the MAC > length (L2 + L3 + L4 headers + payload) of those packets be small > enough to fit within a given length? > > Move skb_gso_mac_seglen() to skbuff.h with other relat

Re: [PATCH v3 1/2] net: create skb_gso_validate_mac_len()

2018-01-29 Thread Daniel Axtens
Hi Eric, >> skb_gso_transport_seglen(skb) is quite expensive (out of line) >> >> It is unfortunate bnx2x seems to support 9600 MTU ( >> ETH_MAX_JUMBO_PACKET_SIZE ), because 100 bytes of headers can be too >> small in some cases. >> >> Presumably we could avoid calling the function for standard M

Re: [PATCH v3 1/2] net: create skb_gso_validate_mac_len()

2018-01-29 Thread Eric Dumazet
On Mon, 2018-01-29 at 17:46 -0800, Eric Dumazet wrote: > On Tue, 2018-01-30 at 12:14 +1100, Daniel Axtens wrote: > > If you take a GSO skb, and split it into packets, will the MAC > > length (L2 + L3 + L4 headers + payload) of those packets be small > > enough to fit within a given length? > > > >

Re: [PATCH v3 1/2] net: create skb_gso_validate_mac_len()

2018-01-29 Thread Eric Dumazet
On Tue, 2018-01-30 at 12:14 +1100, Daniel Axtens wrote: > If you take a GSO skb, and split it into packets, will the MAC > length (L2 + L3 + L4 headers + payload) of those packets be small > enough to fit within a given length? > > Move skb_gso_mac_seglen() to skbuff.h with other related functions

[PATCH v3 1/2] net: create skb_gso_validate_mac_len()

2018-01-29 Thread Daniel Axtens
If you take a GSO skb, and split it into packets, will the MAC length (L2 + L3 + L4 headers + payload) of those packets be small enough to fit within a given length? Move skb_gso_mac_seglen() to skbuff.h with other related functions like skb_gso_network_seglen() so we can use it, and then create s