Re: [PATCH v3 net-next 0/6] tls: Add generic NIC offload infrastructure

Wed, Dec 20, 2017 at 05:36:14PM CET, da...@davemloft.net wrote: >From: Ilya Lesokhin >Date: Wed, 20 Dec 2017 16:23:03 + > >>> Whether you provide the API addition patches and the user in the same patch >>> series, or a separate one, doesn't really matter. What is

Re: [PATCH v3 net-next 0/6] tls: Add generic NIC offload infrastructure

From: Ilya Lesokhin Date: Wed, 20 Dec 2017 16:23:03 + >> Whether you provide the API addition patches and the user in the same patch >> series, or a separate one, doesn't really matter. What is important is that >> this >> is accessible to the reviewer at the same time.

RE: [PATCH v3 net-next 0/6] tls: Add generic NIC offload infrastructure

> > > Dave, would you prefer to get the driver patches that use this infra > > before the infra? > > The arguments you present are silly. > > In order to analyze any proposed API, the users of it must be presented for > the > reviewers to see as well. > > Logically, you must have tried to

Re: [PATCH v3 net-next 0/6] tls: Add generic NIC offload infrastructure

From: Boris Pismenny Date: Wed, 20 Dec 2017 08:28:03 + > Dave, would you prefer to get the driver patches that use this infra > before the infra? The arguments you present are silly. In order to analyze any proposed API, the users of it must be presented for the

Re: [PATCH v3 net-next 0/6] tls: Add generic NIC offload infrastructure

> It is fundamental requirement to show a use-case along with infra-structure. To make it clear, sometimes you don't have yet the full HW/FW/FPGA solution when you come to upstream the infra code. In that case you do the driver code and submit it based on HW emulator run, this is common the

Re: [PATCH v3 net-next 0/6] tls: Add generic NIC offload infrastructure

On Wed, Dec 20, 2017 at 10:28 AM, Boris Pismenny wrote: > Isn't this a chicken and egg problem, where something must come first, > driver or infra. Unless we combine the infra patches with mlx5 driver > code and submit both in a single pull request. why chicken and egg? you

Re: [PATCH v3 net-next 0/6] tls: Add generic NIC offload infrastructure

Wed, Dec 20, 2017 at 09:28:03AM CET, bor...@mellanox.com wrote: > >> Tue, Dec 19, 2017 at 01:10:10AM CET, j...@resnulli.us wrote: >> >> Mon, Dec 18, 2017 at 06:10:10PM CET, j...@resnulli.us wrote: >> >Mon, Dec 18, 2017 at 12:10:27PM CET, il...@mellanox.com wrote: >> >>Changes from v2: >> >>- Fix

RE: [PATCH v3 net-next 0/6] tls: Add generic NIC offload infrastructure

> Tue, Dec 19, 2017 at 01:10:10AM CET, j...@resnulli.us wrote: > > Mon, Dec 18, 2017 at 06:10:10PM CET, j...@resnulli.us wrote: > >Mon, Dec 18, 2017 at 12:10:27PM CET, il...@mellanox.com wrote: > >>Changes from v2: > >>- Fix sk use after free and possible netdev use after free > >>- tls device

Re: [PATCH v3 net-next 0/6] tls: Add generic NIC offload infrastructure

Mon, Dec 18, 2017 at 06:10:10PM CET, j...@resnulli.us wrote: >Mon, Dec 18, 2017 at 12:10:27PM CET, il...@mellanox.com wrote: >>Changes from v2: >>- Fix sk use after free and possible netdev use after free >>- tls device now keeps a refernce on the offloading netdev >>- tls device registers to the

Re: [PATCH v3 net-next 0/6] tls: Add generic NIC offload infrastructure

Mon, Dec 18, 2017 at 12:10:27PM CET, il...@mellanox.com wrote: >Changes from v2: >- Fix sk use after free and possible netdev use after free >- tls device now keeps a refernce on the offloading netdev >- tls device registers to the netdev notifer. > Upon a NETDEV_DOWN event, offload is stopped

[PATCH v3 net-next 0/6] tls: Add generic NIC offload infrastructure

Changes from v2: - Fix sk use after free and possible netdev use after free - tls device now keeps a refernce on the offloading netdev - tls device registers to the netdev notifer. Upon a NETDEV_DOWN event, offload is stopped and the reference on the netdev is dropped. - SW fallback support