Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage

2016-10-17 Thread Jarod Wilson
On Mon, Oct 17, 2016 at 04:07:12PM -0400, Jarod Wilson wrote: > On Mon, Oct 17, 2016 at 01:25:53PM -0400, David Miller wrote: > > From: Jakub Kicinski > > Date: Mon, 17 Oct 2016 18:20:49 +0100 > > > > > Hm. I must be missing something really obvious. I just booted > > > net-next an hour ago and

Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage

2016-10-17 Thread Jarod Wilson
On Mon, Oct 17, 2016 at 01:25:53PM -0400, David Miller wrote: > From: Jakub Kicinski > Date: Mon, 17 Oct 2016 18:20:49 +0100 > > > Hm. I must be missing something really obvious. I just booted > > net-next an hour ago and couldn't set MTU to anything larger than 1500 > > on either nfp or igb.

Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage

2016-10-17 Thread David Miller
From: Jakub Kicinski Date: Mon, 17 Oct 2016 18:20:49 +0100 > Hm. I must be missing something really obvious. I just booted > net-next an hour ago and couldn't set MTU to anything larger than 1500 > on either nfp or igb. As far as I can read the code it will set the > max_mtu to 1500 in setup_e

Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage

2016-10-17 Thread Jakub Kicinski
On Mon, 17 Oct 2016 13:15:13 -0400 (EDT), David Miller wrote: > From: Jakub Kicinski > Date: Mon, 17 Oct 2016 18:00:27 +0100 > > > On Mon, 17 Oct 2016 12:49:54 -0400 (EDT), David Miller wrote: > >> From: Jakub Kicinski > >> Date: Mon, 17 Oct 2016 17:20:06 +0100 > >> > >> > Please correct me

Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage

2016-10-17 Thread David Miller
From: Jakub Kicinski Date: Mon, 17 Oct 2016 18:00:27 +0100 > On Mon, 17 Oct 2016 12:49:54 -0400 (EDT), David Miller wrote: >> From: Jakub Kicinski >> Date: Mon, 17 Oct 2016 17:20:06 +0100 >> >> > Please correct me if I'm wrong but it seems like we are now limiting >> > _all_ ethernet drivers to

Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage

2016-10-17 Thread Jakub Kicinski
On Mon, 17 Oct 2016 18:00:27 +0100, Jakub Kicinski wrote: > On Mon, 17 Oct 2016 12:49:54 -0400 (EDT), David Miller wrote: > > From: Jakub Kicinski > > Date: Mon, 17 Oct 2016 17:20:06 +0100 > > > > > Please correct me if I'm wrong but it seems like we are now limiting > > > _all_ ethernet driver

Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage

2016-10-17 Thread Jakub Kicinski
On Mon, 17 Oct 2016 12:49:54 -0400 (EDT), David Miller wrote: > From: Jakub Kicinski > Date: Mon, 17 Oct 2016 17:20:06 +0100 > > > Please correct me if I'm wrong but it seems like we are now limiting > > _all_ ethernet drivers to ETH_DATA_LEN in net-next. > > No, because the driver can increas

Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage

2016-10-17 Thread David Miller
From: Jakub Kicinski Date: Mon, 17 Oct 2016 17:20:06 +0100 > Please correct me if I'm wrong but it seems like we are now limiting > _all_ ethernet drivers to ETH_DATA_LEN in net-next. No, because the driver can increase the netdev->max_mtu value as needed.

Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage

2016-10-17 Thread Jakub Kicinski
On Fri, 7 Oct 2016 22:04:34 -0400, Jarod Wilson wrote: > @@ -357,6 +356,8 @@ void ether_setup(struct net_device *dev) > dev->type = ARPHRD_ETHER; > dev->hard_header_len= ETH_HLEN; > dev->mtu= ETH_DATA_LEN; > + dev->min_mtu= ETH_MI

[PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage

2016-10-07 Thread Jarod Wilson
With centralized MTU checking, there's nothing productive done by eth_change_mtu that isn't already done in dev_set_mtu, so mark it as deprecated and remove all usage of it in the kernel. All callers have been audited for calls to alloc_etherdev* or ether_setup directly, which means they all have a