Re: [PATCH v3 net-next v3 10/14] net: dsa: mv88e6xxx: add SMI init helper

2016-06-18 Thread Andrew Lunn
On Fri, Jun 17, 2016 at 08:07:32PM -0400, Vivien Didelot wrote: > Add an helper function to isolate SMI specific assignations and checks. I don't think you meant assignations. Assignments? Otherwise Reviewed-by: Andrew Lunn Andrew

[PATCH v3 net-next v3 10/14] net: dsa: mv88e6xxx: add SMI init helper

2016-06-17 Thread Vivien Didelot
Add an helper function to isolate SMI specific assignations and checks. This function will later help choosing the different SMI accesses based of the compatible info. Since the chip structure is already allocated in the legacy probe, use the mv88e6xxx_reg_read access routine instead of __mv88e6x