[PATCH v3 net 1/5] ipv6: Refactor common ip6gre_tunnel_init codes

2015-09-11 Thread Martin KaFai Lau
It is a prep work to fix the dst_entry refcnt bugs in ip6_tunnel. This patch refactors some common init codes used by both ip6gre_tunnel_init and ip6gre_tap_init. Signed-off-by: Martin KaFai Lau --- net/ipv6/ip6_gre.c | 37 - 1 file changed, 24

Re: [PATCH v3 net 1/5] ipv6: Refactor common ip6gre_tunnel_init codes

2015-09-11 Thread David Miller
From: Martin KaFai Lau Date: Fri, 11 Sep 2015 11:06:17 -0700 > @@ -1460,19 +1474,16 @@ static void ip6gre_netlink_parms(struct nlattr > *data[], > static int ip6gre_tap_init(struct net_device *dev) > { > struct ip6_tnl *tunnel; > + int ret; > > - tunnel =

Re: [PATCH v3 net 1/5] ipv6: Refactor common ip6gre_tunnel_init codes

2015-09-11 Thread Martin KaFai Lau
On Fri, Sep 11, 2015 at 03:30:59PM -0700, David Miller wrote: > From: Martin KaFai Lau > Date: Fri, 11 Sep 2015 11:06:17 -0700 > > > @@ -1460,19 +1474,16 @@ static void ip6gre_netlink_parms(struct nlattr > > *data[], > > static int ip6gre_tap_init(struct net_device *dev) > > { >

Re: [PATCH v3 net 1/5] ipv6: Refactor common ip6gre_tunnel_init codes

2015-09-11 Thread David Miller
From: Martin KaFai Lau Date: Fri, 11 Sep 2015 16:20:26 -0700 > or I am missing something and have overlooked a bug? My bad, I simply misread your patch. Sorry about that. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to