RE: [PATCH v4 net-next]smsc911x: Adding support for Micochip LAN9250 Ethernet controller

2017-05-01 Thread Woojung.Huh
> Isn't this now pointless? If it is not used anywhere, you should not > add it. > Andrew, David is going to submit another patch. (He already sent discard request email right after v4 patch.) - Woojung

Re: [PATCH v4 net-next]smsc911x: Adding support for Micochip LAN9250 Ethernet controller

2017-04-28 Thread Andrew Lunn
On Fri, Apr 28, 2017 at 10:28:32PM +, david@microchip.com wrote: > From: David Cai > > Adding support for Microchip LAN9250 Ethernet controller. > > Signed-off-by: David Cai > --- > Changes > V2 > - email format changed > - remove unnecessary text in commit log Changes > V3 > - defin

please discard [PATCH v4 net-next]smsc911x: Adding support for Micochip LAN9250 Ethernet controller

2017-04-28 Thread David.Cai
HiAndrew: Please discard the [PATCH v4 net-next]smsc911x: Adding support for Micochip LAN9250 Ethernet controller which I just submit, Because I found the new variable 'sub_generation' don't need any more. I will submit v5 to do this Thanks David Cai

[PATCH v4 net-next]smsc911x: Adding support for Micochip LAN9250 Ethernet controller

2017-04-28 Thread David.Cai
From: David Cai Adding support for Microchip LAN9250 Ethernet controller. Signed-off-by: David Cai --- Changes V2 - email format changed - remove unnecessary text in commit log Changes V3 - defined all supported Ethernet controller chip ID. V4 - changed 'if (pdata->generation == 4 && pdata-