Re: [PATCH v5 0/2] skb_array: array based FIFO for skbs

2016-05-30 Thread Jason Wang
On 2016年05月30日 23:37, Michael S. Tsirkin wrote: On Mon, May 30, 2016 at 05:59:33PM +0800, Jason Wang wrote: On 2016年05月23日 18:43, Michael S. Tsirkin wrote: This is in response to the proposal by Jason to make tun rx packet queue lockless using a circular buffer. My testing seems to show

Re: [PATCH v5 0/2] skb_array: array based FIFO for skbs

2016-05-30 Thread Michael S. Tsirkin
On Mon, May 30, 2016 at 05:59:33PM +0800, Jason Wang wrote: > > > On 2016年05月23日 18:43, Michael S. Tsirkin wrote: > >This is in response to the proposal by Jason to make tun > >rx packet queue lockless using a circular buffer. > >My testing seems to show that at least for the common usecase >

Re: [PATCH v5 0/2] skb_array: array based FIFO for skbs

2016-05-30 Thread Jason Wang
On 2016年05月23日 18:43, Michael S. Tsirkin wrote: This is in response to the proposal by Jason to make tun rx packet queue lockless using a circular buffer. My testing seems to show that at least for the common usecase in networking, which isn't lockless, circular buffer with indices does not

Re: [PATCH v5 0/2] skb_array: array based FIFO for skbs

2016-05-23 Thread Michael S. Tsirkin
On Mon, May 23, 2016 at 06:31:46AM -0700, Eric Dumazet wrote: > On Mon, 2016-05-23 at 13:43 +0300, Michael S. Tsirkin wrote: > > This is in response to the proposal by Jason to make tun > > rx packet queue lockless using a circular buffer. > > My testing seems to show that at least for the common

Re: [PATCH v5 0/2] skb_array: array based FIFO for skbs

2016-05-23 Thread Eric Dumazet
On Mon, 2016-05-23 at 13:43 +0300, Michael S. Tsirkin wrote: > This is in response to the proposal by Jason to make tun > rx packet queue lockless using a circular buffer. > My testing seems to show that at least for the common usecase > in networking, which isn't lockless, circular buffer > with

[PATCH v5 0/2] skb_array: array based FIFO for skbs

2016-05-23 Thread Michael S. Tsirkin
This is in response to the proposal by Jason to make tun rx packet queue lockless using a circular buffer. My testing seems to show that at least for the common usecase in networking, which isn't lockless, circular buffer with indices does not perform that well, because each index access causes a