Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-14 Thread David VomLehn
On 01/14/2017 10:48 AM, Florian Fainelli wrote: On 01/14/2017 10:42 AM, David VomLehn wrote: Yes, we did have it that way at one point. But...there is also the kernel philosophy of not putting in something for future expansion; you can always do it later... Honestly, I've vacillated on this

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-14 Thread Florian Fainelli
On 01/14/2017 10:42 AM, David VomLehn wrote: > Yes, we did have it that way at one point. But...there is also the > kernel philosophy of not putting in something for future expansion; you > can always do it later... Honestly, I've vacillated on this particular one. (please don't top post). There

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-14 Thread David VomLehn
Yes, we did have it that way at one point. But...there is also the kernel philosophy of not putting in something for future expansion; you can always do it later... Honestly, I've vacillated on this particular one. On 01/14/2017 10:39 AM, Florian Fainelli wrote: On 01/12/2017 09:02 PM,

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-14 Thread Florian Fainelli
On 01/12/2017 09:02 PM, Alexander Loktionov wrote: > From: David VomLehn > > Patches to create the make and configuration files. > > Signed-off-by: Alexander Loktionov > Signed-off-by: Dmitrii Tarakanov >

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-13 Thread Florian Fainelli
On 01/12/2017 09:02 PM, Alexander Loktionov wrote: > From: David VomLehn > > Patches to create the make and configuration files. > > Signed-off-by: Alexander Loktionov > Signed-off-by: Dmitrii Tarakanov >

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-12 Thread Joe Perches
On Thu, 2017-01-12 at 22:57 -0800, David VomLehn wrote: > On 01/12/2017 09:59 PM, Joe Perches wrote: > > On Thu, 2017-01-12 at 21:24 -0800, David VomLehn wrote: > > > On 01/12/2017 09:06 PM, Joe Perches wrote: > > > > On Thu, 2017-01-12 at 21:02 -0800, Alexander Loktionov wrote: > > > > > From:

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-12 Thread David VomLehn
On 01/12/2017 09:59 PM, Joe Perches wrote: On Thu, 2017-01-12 at 21:24 -0800, David VomLehn wrote: On 01/12/2017 09:06 PM, Joe Perches wrote: On Thu, 2017-01-12 at 21:02 -0800, Alexander Loktionov wrote: From: David VomLehn Patches to create the make and configuration

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-12 Thread Joe Perches
On Thu, 2017-01-12 at 21:24 -0800, David VomLehn wrote: > On 01/12/2017 09:06 PM, Joe Perches wrote: > > On Thu, 2017-01-12 at 21:02 -0800, Alexander Loktionov wrote: > > > From: David VomLehn > > > > > > Patches to create the make and configuration files. > > > > This patch

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-12 Thread David VomLehn
On 01/12/2017 09:06 PM, Joe Perches wrote: On Thu, 2017-01-12 at 21:02 -0800, Alexander Loktionov wrote: From: David VomLehn Patches to create the make and configuration files. This patch should _really_ be the last in the series not the first. Could you explain the basis

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-12 Thread Joe Perches
On Thu, 2017-01-12 at 21:02 -0800, Alexander Loktionov wrote: > From: David VomLehn > > Patches to create the make and configuration files. This patch should _really_ be the last in the series not the first.

[PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-12 Thread Alexander Loktionov
From: David VomLehn Patches to create the make and configuration files. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous