Re: [PATCH v5 01/32] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

2016-07-14 Thread David Miller
From: Andy Lutomirski Date: Thu, 14 Jul 2016 12:10:45 -0700 > On Mon, Jul 11, 2016 at 1:53 PM, Andy Lutomirski wrote: >> SMP does ECB crypto on stack buffers. This is complicated and >> fragile, and it will not work if the stack is virtually allocated. >>

Re: [PATCH v5 01/32] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

2016-07-14 Thread Marcel Holtmann
Hi Andy, >> SMP does ECB crypto on stack buffers. This is complicated and >> fragile, and it will not work if the stack is virtually allocated. >> >> Switch to the crypto_cipher interface, which is simpler and safer. > > Hi Dave- > > It looks like we're delaying virtually mapped stacks to

Re: [PATCH v5 01/32] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

2016-07-14 Thread Andy Lutomirski
On Mon, Jul 11, 2016 at 1:53 PM, Andy Lutomirski wrote: > SMP does ECB crypto on stack buffers. This is complicated and > fragile, and it will not work if the stack is virtually allocated. > > Switch to the crypto_cipher interface, which is simpler and safer. Hi Dave- It looks

[PATCH v5 01/32] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

2016-07-11 Thread Andy Lutomirski
SMP does ECB crypto on stack buffers. This is complicated and fragile, and it will not work if the stack is virtually allocated. Switch to the crypto_cipher interface, which is simpler and safer. Cc: Marcel Holtmann Cc: Gustavo Padovan Cc: Johan