Re: [PATCH v5 02/14] net: pch_gbe: Pull PHY GPIO handling out of Minnow code

2018-02-18 Thread Andrew Lunn
> How would you feel if I were to adjust the binding to match the standard > PHY binding, but internally leave the driver's PHY handling as-is for > now? Hi Paul That is a reasonable compromise. Thanks Andrew

Re: [PATCH v5 02/14] net: pch_gbe: Pull PHY GPIO handling out of Minnow code

2018-02-18 Thread Paul Burton
Hi Andrew, On Sun, Feb 18, 2018 at 12:34:42AM +0100, Andrew Lunn wrote: > > Even if that is true, rewriting the driver's PHY handling would be a > > very separate change to the changes this series make which allow this > > driver to work on a platform besides the Minnowboard. The *only* thing > >

Re: [PATCH v5 02/14] net: pch_gbe: Pull PHY GPIO handling out of Minnow code

2018-02-17 Thread Andrew Lunn
> Note that this is a driver which is already in mainline, and I didn't > write it. Claiming that *I* am doing this all wrong is a bit of a > stretch - all this patch does is make small changes to some existing > code, which only tangentially relates to a PHY driver, such that it > ceases to be

Re: [PATCH v5 02/14] net: pch_gbe: Pull PHY GPIO handling out of Minnow code

2018-02-17 Thread Paul Burton
Hi Andrew, On Sat, Feb 17, 2018 at 11:29:33PM +0100, Andrew Lunn wrote: > On Sat, Feb 17, 2018 at 12:10:25PM -0800, Paul Burton wrote: > > The MIPS Boston development board uses the Intel EG20T Platform > > Controller Hub, including its gigabit ethernet controller, and requires > > that its

Re: [PATCH v5 02/14] net: pch_gbe: Pull PHY GPIO handling out of Minnow code

2018-02-17 Thread Andrew Lunn
On Sat, Feb 17, 2018 at 12:10:25PM -0800, Paul Burton wrote: > The MIPS Boston development board uses the Intel EG20T Platform > Controller Hub, including its gigabit ethernet controller, and requires > that its RTL8211E PHY be reset much like the Minnow platform. Pull the > PHY reset GPIO

[PATCH v5 02/14] net: pch_gbe: Pull PHY GPIO handling out of Minnow code

2018-02-17 Thread Paul Burton
The MIPS Boston development board uses the Intel EG20T Platform Controller Hub, including its gigabit ethernet controller, and requires that its RTL8211E PHY be reset much like the Minnow platform. Pull the PHY reset GPIO handling out of Minnow-specific code such that it can be shared by later