Re: [PATCH v5 bpf-next 3/3] selftests/bpf: add raw_tp_test_run

2020-09-25 Thread Song Liu
> On Sep 25, 2020, at 10:31 AM, Andrii Nakryiko > wrote: > > On Thu, Sep 24, 2020 at 4:03 PM Song Liu wrote: >> >> This test runs test_run for raw_tracepoint program. The test covers ctx >> input, retval output, and running on correct cpu. >> >> Signed-off-by: Song Liu >> --- > > Few sug

Re: [PATCH v5 bpf-next 3/3] selftests/bpf: add raw_tp_test_run

2020-09-25 Thread Andrii Nakryiko
On Thu, Sep 24, 2020 at 4:03 PM Song Liu wrote: > > This test runs test_run for raw_tracepoint program. The test covers ctx > input, retval output, and running on correct cpu. > > Signed-off-by: Song Liu > --- Few suggestions below, but overall looks good to me: Acked-by: Andrii Nakryiko > .

Re: [PATCH v5 bpf-next 3/3] selftests/bpf: add raw_tp_test_run

2020-09-24 Thread Song Liu
> On Sep 24, 2020, at 6:01 PM, John Fastabend wrote: > > Song Liu wrote: >> This test runs test_run for raw_tracepoint program. The test covers ctx >> input, retval output, and running on correct cpu. >> >> Signed-off-by: Song Liu >> --- > > [...] > >> +void test_raw_tp_test_run(void) >> +

RE: [PATCH v5 bpf-next 3/3] selftests/bpf: add raw_tp_test_run

2020-09-24 Thread John Fastabend
Song Liu wrote: > This test runs test_run for raw_tracepoint program. The test covers ctx > input, retval output, and running on correct cpu. > > Signed-off-by: Song Liu > --- [...] > +void test_raw_tp_test_run(void) > +{ > + struct bpf_prog_test_run_attr test_attr = {}; > + int comm_fd

[PATCH v5 bpf-next 3/3] selftests/bpf: add raw_tp_test_run

2020-09-24 Thread Song Liu
This test runs test_run for raw_tracepoint program. The test covers ctx input, retval output, and running on correct cpu. Signed-off-by: Song Liu --- .../bpf/prog_tests/raw_tp_test_run.c | 98 +++ .../bpf/progs/test_raw_tp_test_run.c | 24 + 2 files changed,