Re: [Intel-wired-lan] [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

2015-12-03 Thread Sowmini Varadhan
On (12/03/15 16:53), Bowers, AndrewX wrote: > > I get an error -11 on driver init with this patch applied, I can > revert it and everything works normally. Dmesg screenshot is attached, > can supply complete dmesg log if needed. Yes, that's the same thing that I'm running into as well. Using th

Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-05 Thread Andy Shevchenko
On Thu, Nov 5, 2015 at 8:31 PM, David Miller wrote: > From: Andy Shevchenko > Date: Thu, 5 Nov 2015 20:13:21 +0200 > >> What about >> >> if (!addr) >> return -ENODATA; > > I totally disagree. of_get_phy_mode() and other similar attribute > probing mechanisms use -ENODEV. Okay, then just if (!a

Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-05 Thread David Miller
From: Andy Shevchenko Date: Thu, 5 Nov 2015 20:13:21 +0200 > What about > > if (!addr) > return -ENODATA; I totally disagree. of_get_phy_mode() and other similar attribute probing mechanisms use -ENODEV. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a mes

Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-05 Thread Andy Shevchenko
On Thu, Nov 5, 2015 at 6:05 PM, David Miller wrote: > From: David Miller > Date: Thu, 05 Nov 2015 10:31:26 -0500 (EST) > >> I'll see if I can cook something up. > > How does this look? I like it, though couple of style related comments. > > > net: Add eth_platform_get_mac_a

RE: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-05 Thread Nelson, Shannon
> From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, November 05, 2015 8:29 AM > > From: Sowmini Varadhan > Date: Thu, 5 Nov 2015 11:28:31 -0500 > > > On (11/05/15 11:05), David Miller wrote: > >> From: David Miller > >> Date: Thu, 05 Nov 2015 10:31:26 -0500 (EST) > >> > >> > I'l

Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-05 Thread Sowmini Varadhan
On (11/05/15 11:29), David Miller wrote: > > The intention is to let your patch go in as-is, then try and update > ixgbe/i40e later in net-next or similar. Sounds good, I can take care of ixgbe/i40e after that happens. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-05 Thread Sowmini Varadhan
On (11/05/15 11:05), David Miller wrote: > From: David Miller > Date: Thu, 05 Nov 2015 10:31:26 -0500 (EST) > > > I'll see if I can cook something up. > > How does this look? Looks good to me, Do you want me to respin patch v7 with this? Or update ixgbe/i40e to use this later, after this goes

Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-05 Thread David Miller
From: Sowmini Varadhan Date: Thu, 5 Nov 2015 11:28:31 -0500 > On (11/05/15 11:05), David Miller wrote: >> From: David Miller >> Date: Thu, 05 Nov 2015 10:31:26 -0500 (EST) >> >> > I'll see if I can cook something up. >> >> How does this look? > > Looks good to me, > > Do you want me to respi

Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-05 Thread David Miller
From: David Miller Date: Thu, 05 Nov 2015 10:31:26 -0500 (EST) > I'll see if I can cook something up. How does this look? net: Add eth_platform_get_mac_address() helper. A repeating pattern in drivers has become to use OF node information and, if not found, platform specif

Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-05 Thread David Miller
From: Sowmini Varadhan Date: Wed, 4 Nov 2015 18:21:00 -0500 > This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC > address in Open Firmware or IDPROM"). > > As with that fix, attempt to look up the MAC address in Open Firmware > on systems that support it, and use IDPROM on

RE: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-04 Thread Nelson, Shannon
> From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: Wednesday, November 04, 2015 3:21 PM > > This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC > address in Open Firmware or IDPROM"). > > As with that fix, attempt to look up the MAC address in Open Firmware

[PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

2015-11-04 Thread Sowmini Varadhan
This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC address in Open Firmware or IDPROM"). As with that fix, attempt to look up the MAC address in Open Firmware on systems that support it, and use IDPROM on SPARC if no OF address is found. In the case of the i40e there is an a