Re: [PATCH v8 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-10 Thread Rob Herring
On Wed, Oct 05, 2016 at 05:09:38PM +0530, Raju Lakkaraju wrote: > From: Raju Lakkaraju > > Edge-rate: > As system and networking speeds increase, a signal's output transition, > also know as the edge rate or slew rate (V/ns), takes on greater importance > because

Re: [PATCH v8 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-05 Thread Andrew Lunn
> - As per review comment, Added DT vddmac, slowdown value error check. So i said an exact match, which this is not. How about something like: static u8 vsc85xx_edge_rate_magic_get(u16 vddmac, u8 slowdown) { u8 vdd; u8 sd; for (vdd = 0; vdd < ARRAY_SIZE(edge_table);

[PATCH v8 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-05 Thread Raju Lakkaraju
From: Raju Lakkaraju Edge-rate: As system and networking speeds increase, a signal's output transition, also know as the edge rate or slew rate (V/ns), takes on greater importance because high-speed signals come with a price. That price is an assortment of