Re: [PATCHv2 net] net/flow: fix fc->percpu NULL pointer dereference

2017-06-10 Thread Hangbin Liu
On Sat, Jun 10, 2017 at 04:29:23PM +0800, Xin Long wrote: > It's a xfrm fix, pls also fix the title, like: >xfrm: move xfrm_garbage_collect out of xfrm_policy_flush > or >xfrm: fix ... Opps, sorry forgot that.

Re: [PATCHv2 net] net/flow: fix fc->percpu NULL pointer dereference

2017-06-10 Thread Xin Long
On Fri, Jun 9, 2017 at 9:09 PM, Hangbin Liu wrote: > Now we will force to do garbage collection if any policy removed in > xfrm_policy_flush(). But during xfrm_net_exit(). We call flow_cache_fini() > first and set set fc->percpu to NULL. Then after we call xfrm_policy_fini() > -> frxm_policy_flush

[PATCHv2 net] net/flow: fix fc->percpu NULL pointer dereference

2017-06-09 Thread Hangbin Liu
Now we will force to do garbage collection if any policy removed in xfrm_policy_flush(). But during xfrm_net_exit(). We call flow_cache_fini() first and set set fc->percpu to NULL. Then after we call xfrm_policy_fini() -> frxm_policy_flush() -> flow_cache_flush(), we will get NULL pointer dereferen