Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2019-02-03 Thread Xin Long
On Sat, Feb 2, 2019 at 2:38 AM David Miller wrote: > > From: Neil Horman > Date: Fri, 1 Feb 2019 07:31:18 -0500 > > > On Thu, Jan 31, 2019 at 10:39:41PM -0200, Marcelo Ricardo Leitner wrote: > >> On Tue, Jan 29, 2019 at 07:58:07PM +0100, Tuxdriver wrote: > >> > I was initially under the impressio

Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2019-02-01 Thread David Miller
From: Neil Horman Date: Fri, 1 Feb 2019 07:31:18 -0500 > On Thu, Jan 31, 2019 at 10:39:41PM -0200, Marcelo Ricardo Leitner wrote: >> On Tue, Jan 29, 2019 at 07:58:07PM +0100, Tuxdriver wrote: >> > I was initially under the impression that with Kent's repost, the radixtree >> > (which is what I th

Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2019-02-01 Thread Neil Horman
On Thu, Jan 31, 2019 at 10:39:41PM -0200, Marcelo Ricardo Leitner wrote: > On Tue, Jan 29, 2019 at 07:58:07PM +0100, Tuxdriver wrote: > > I was initially under the impression that with Kent's repost, the radixtree > > (which is what I think you meant by rhashtables) updates would be merged > > Oop

Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2019-01-31 Thread Marcelo Ricardo Leitner
On Tue, Jan 29, 2019 at 07:58:07PM +0100, Tuxdriver wrote: > I was initially under the impression that with Kent's repost, the radixtree > (which is what I think you meant by rhashtables) updates would be merged Oops! Yep.. I had meant flex_arrays actually. > imminently, but that doesn't seem to

Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2019-01-29 Thread Tuxdriver
I was initially under the impression that with Kent's repost, the radixtree (which is what I think you meant by rhashtables) updates would be merged imminently, but that doesn't seem to be the case. I'd really like to know what the hold up there is, as that patch seems to have been stalled for

Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2019-01-29 Thread Marcelo Ricardo Leitner
On Thu, Nov 29, 2018 at 02:42:56PM +0800, Xin Long wrote: > Now when using stream reconfig to add out streams, stream->out > will get re-allocated, and all old streams' information will > be copied to the new ones and the old ones will be freed. > > So without stream->out_curr updated, next time w

Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2018-11-30 Thread Neil Horman
On Sat, Dec 01, 2018 at 03:53:26AM +0900, Xin Long wrote: > On Sat, Dec 1, 2018 at 12:23 AM Neil Horman wrote: > > > > On Fri, Nov 30, 2018 at 10:48:10PM +0900, Xin Long wrote: > > > On Fri, Nov 30, 2018 at 9:21 PM Neil Horman wrote: > > > > > > > > On Fri, Nov 30, 2018 at 03:22:39PM +0900, Xin L

Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2018-11-30 Thread Neil Horman
On Sat, Dec 01, 2018 at 03:53:26AM +0900, Xin Long wrote: > On Sat, Dec 1, 2018 at 12:23 AM Neil Horman wrote: > > > > On Fri, Nov 30, 2018 at 10:48:10PM +0900, Xin Long wrote: > > > On Fri, Nov 30, 2018 at 9:21 PM Neil Horman wrote: > > > > > > > > On Fri, Nov 30, 2018 at 03:22:39PM +0900, Xin L

Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2018-11-30 Thread Xin Long
On Sat, Dec 1, 2018 at 12:23 AM Neil Horman wrote: > > On Fri, Nov 30, 2018 at 10:48:10PM +0900, Xin Long wrote: > > On Fri, Nov 30, 2018 at 9:21 PM Neil Horman wrote: > > > > > > On Fri, Nov 30, 2018 at 03:22:39PM +0900, Xin Long wrote: > > > > On Thu, Nov 29, 2018 at 11:39 PM Neil Horman > >

Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2018-11-30 Thread Neil Horman
On Fri, Nov 30, 2018 at 10:48:10PM +0900, Xin Long wrote: > On Fri, Nov 30, 2018 at 9:21 PM Neil Horman wrote: > > > > On Fri, Nov 30, 2018 at 03:22:39PM +0900, Xin Long wrote: > > > On Thu, Nov 29, 2018 at 11:39 PM Neil Horman > > > wrote: > > > > > > > > On Thu, Nov 29, 2018 at 02:42:56PM +080

Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2018-11-30 Thread Xin Long
On Fri, Nov 30, 2018 at 9:21 PM Neil Horman wrote: > > On Fri, Nov 30, 2018 at 03:22:39PM +0900, Xin Long wrote: > > On Thu, Nov 29, 2018 at 11:39 PM Neil Horman wrote: > > > > > > On Thu, Nov 29, 2018 at 02:42:56PM +0800, Xin Long wrote: > > > > Now when using stream reconfig to add out streams,

Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2018-11-30 Thread Neil Horman
On Fri, Nov 30, 2018 at 03:22:39PM +0900, Xin Long wrote: > On Thu, Nov 29, 2018 at 11:39 PM Neil Horman wrote: > > > > On Thu, Nov 29, 2018 at 02:42:56PM +0800, Xin Long wrote: > > > Now when using stream reconfig to add out streams, stream->out > > > will get re-allocated, and all old streams' i

Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2018-11-29 Thread Xin Long
On Thu, Nov 29, 2018 at 11:39 PM Neil Horman wrote: > > On Thu, Nov 29, 2018 at 02:42:56PM +0800, Xin Long wrote: > > Now when using stream reconfig to add out streams, stream->out > > will get re-allocated, and all old streams' information will > > be copied to the new ones and the old ones will

Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2018-11-29 Thread Neil Horman
On Thu, Nov 29, 2018 at 02:42:56PM +0800, Xin Long wrote: > Now when using stream reconfig to add out streams, stream->out > will get re-allocated, and all old streams' information will > be copied to the new ones and the old ones will be freed. > > So without stream->out_curr updated, next time w

Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2018-11-29 Thread Xin Long
On Thu, Nov 29, 2018 at 9:50 PM Neil Horman wrote: > > On Thu, Nov 29, 2018 at 02:42:56PM +0800, Xin Long wrote: > > Now when using stream reconfig to add out streams, stream->out > > will get re-allocated, and all old streams' information will > > be copied to the new ones and the old ones will b

Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2018-11-29 Thread Neil Horman
On Thu, Nov 29, 2018 at 02:42:56PM +0800, Xin Long wrote: > Now when using stream reconfig to add out streams, stream->out > will get re-allocated, and all old streams' information will > be copied to the new ones and the old ones will be freed. > > So without stream->out_curr updated, next time w

[PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2018-11-28 Thread Xin Long
Now when using stream reconfig to add out streams, stream->out will get re-allocated, and all old streams' information will be copied to the new ones and the old ones will be freed. So without stream->out_curr updated, next time when trying to send from stream->out_curr stream, a panic would be ca