Re: [PATCHv3 1/4] rds: ib: drop unnecessary rdma_reject

2017-03-13 Thread Leon Romanovsky
On Mon, Mar 13, 2017 at 02:41:10PM +0800, Yanjun Zhu wrote: > > > On 2017/3/13 14:32, Leon Romanovsky wrote: > > On Mon, Mar 13, 2017 at 01:43:45AM -0400, Zhu Yanjun wrote: > > > When rdma_accept fails, rdma_reject is called in it. As such, it is > > > not necessary to execute rdma_reject again. >

Re: [PATCHv3 1/4] rds: ib: drop unnecessary rdma_reject

2017-03-13 Thread Yanjun Zhu
On 2017/3/13 14:32, Leon Romanovsky wrote: On Mon, Mar 13, 2017 at 01:43:45AM -0400, Zhu Yanjun wrote: When rdma_accept fails, rdma_reject is called in it. As such, it is not necessary to execute rdma_reject again. It is not always correct, according to the code, rdma_accept can fail and

Re: [PATCHv3 1/4] rds: ib: drop unnecessary rdma_reject

2017-03-13 Thread Leon Romanovsky
On Mon, Mar 13, 2017 at 01:43:45AM -0400, Zhu Yanjun wrote: > When rdma_accept fails, rdma_reject is called in it. As such, it is > not necessary to execute rdma_reject again. It is not always correct, according to the code, rdma_accept can fail and will return EINVAL and skip calling to

[PATCHv3 1/4] rds: ib: drop unnecessary rdma_reject

2017-03-12 Thread Zhu Yanjun
When rdma_accept fails, rdma_reject is called in it. As such, it is not necessary to execute rdma_reject again. Cc: Joe Jin Cc: Junxiao Bi Acked-by: Santosh Shilimkar Signed-off-by: Zhu Yanjun ---