Re: [PATCHv3 net-next 3/4] sctp: add support for generating stream reconf add incoming/outgoing streams request chunk

2017-01-29 Thread David Miller
From: marcelo.leit...@gmail.com Date: Sun, 29 Jan 2017 12:31:17 -0200 > On Mon, Jan 23, 2017 at 10:58:10AM -0500, David Miller wrote: >> If this is "so critical" for end to end communication, why the heck >> do you not see __packed sprinkled all over our definitions for IPV4, >> IPV6, TCP, UDP, et

Re: [PATCHv3 net-next 3/4] sctp: add support for generating stream reconf add incoming/outgoing streams request chunk

2017-01-29 Thread marcelo . leitner
On Mon, Jan 23, 2017 at 10:58:10AM -0500, David Miller wrote: > If this is "so critical" for end to end communication, why the heck > do you not see __packed sprinkled all over our definitions for IPV4, > IPV6, TCP, UDP, etc. headers? > > Do you know why? Because it's completely unnecessary... B

Re: [PATCHv3 net-next 3/4] sctp: add support for generating stream reconf add incoming/outgoing streams request chunk

2017-01-23 Thread David Miller
From: marcelo.leit...@gmail.com Date: Mon, 23 Jan 2017 14:14:58 -0200 > On Mon, Jan 23, 2017 at 11:00:47AM -0500, David Miller wrote: >> I will not accept __packed being used unless it is absolutely, provably, >> the only way to solve a particular problem. And when that does happen, >> I am going

Re: [PATCHv3 net-next 3/4] sctp: add support for generating stream reconf add incoming/outgoing streams request chunk

2017-01-23 Thread marcelo . leitner
On Mon, Jan 23, 2017 at 11:00:47AM -0500, David Miller wrote: > From: "'Marcelo Ricardo Leitner'" > Date: Mon, 23 Jan 2017 10:36:28 -0200 > > > So, no padding. A field just after the other, which is what we want on a > > network header. > > It isn't necessary! > > Show me a case where it is req

Re: [PATCHv3 net-next 3/4] sctp: add support for generating stream reconf add incoming/outgoing streams request chunk

2017-01-23 Thread David Miller
From: "'Marcelo Ricardo Leitner'" Date: Mon, 23 Jan 2017 10:36:28 -0200 > So, no padding. A field just after the other, which is what we want on a > network header. It isn't necessary! Show me a case where it is required when you use properly fixed sized types and a proper ordering of the struc

Re: [PATCHv3 net-next 3/4] sctp: add support for generating stream reconf add incoming/outgoing streams request chunk

2017-01-23 Thread David Miller
From: David Laight Date: Mon, 23 Jan 2017 12:26:12 + > From: Marcelo Ricardo Leitner > Sent: 20 January 2017 16:39 >> To: David Laight >> On Fri, Jan 20, 2017 at 02:50:01PM +, David Laight wrote: >> > From: Xin Long >> > > Sent: 19 January 2017 17:19 >> > > This patch is to define Add Inc

Re: [PATCHv3 net-next 3/4] sctp: add support for generating stream reconf add incoming/outgoing streams request chunk

2017-01-23 Thread 'Marcelo Ricardo Leitner'
On Mon, Jan 23, 2017 at 12:26:12PM +, David Laight wrote: > From: Marcelo Ricardo Leitner > Sent: 20 January 2017 16:39 > > To: David Laight > > On Fri, Jan 20, 2017 at 02:50:01PM +, David Laight wrote: > > > From: Xin Long > > > > Sent: 19 January 2017 17:19 > > > > This patch is to define

RE: [PATCHv3 net-next 3/4] sctp: add support for generating stream reconf add incoming/outgoing streams request chunk

2017-01-23 Thread David Laight
From: Marcelo Ricardo Leitner > Sent: 20 January 2017 16:39 > To: David Laight > On Fri, Jan 20, 2017 at 02:50:01PM +, David Laight wrote: > > From: Xin Long > > > Sent: 19 January 2017 17:19 > > > This patch is to define Add Incoming/Outgoing Streams Request > > > Parameter described in rfc652

Re: [PATCHv3 net-next 3/4] sctp: add support for generating stream reconf add incoming/outgoing streams request chunk

2017-01-20 Thread Marcelo Ricardo Leitner
On Fri, Jan 20, 2017 at 02:50:01PM +, David Laight wrote: > From: Xin Long > > Sent: 19 January 2017 17:19 > > This patch is to define Add Incoming/Outgoing Streams Request > > Parameter described in rfc6525 section 4.5 and 4.6. They can > > be in one same chunk trunk as rfc6525 section 3.1-7 d

RE: [PATCHv3 net-next 3/4] sctp: add support for generating stream reconf add incoming/outgoing streams request chunk

2017-01-20 Thread David Laight
From: Xin Long > Sent: 19 January 2017 17:19 > This patch is to define Add Incoming/Outgoing Streams Request > Parameter described in rfc6525 section 4.5 and 4.6. They can > be in one same chunk trunk as rfc6525 section 3.1-7 describes, > so make them in one function. ... > +struct sctp_strreset_ad

[PATCHv3 net-next 3/4] sctp: add support for generating stream reconf add incoming/outgoing streams request chunk

2017-01-19 Thread Xin Long
This patch is to define Add Incoming/Outgoing Streams Request Parameter described in rfc6525 section 4.5 and 4.6. They can be in one same chunk trunk as rfc6525 section 3.1-7 describes, so make them in one function. Signed-off-by: Xin Long --- include/linux/sctp.h | 7 +++ include/net/s