[PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-19 Thread Xin Long
This patch is to implement Sender-Side Procedures for the Add Outgoing and Incoming Streams Request Parameter described in rfc6525 section 5.1.5-5.1.6. It is also to add sockopt SCTP_ADD_STREAMS in rfc6525 section 6.3.4 for users. Signed-off-by: Xin Long --- include/net/sctp/sctp.h | 2 + in

Re: [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-19 Thread Neil Horman
On Fri, Jan 20, 2017 at 01:19:14AM +0800, Xin Long wrote: > This patch is to implement Sender-Side Procedures for the Add > Outgoing and Incoming Streams Request Parameter described in > rfc6525 section 5.1.5-5.1.6. > > It is also to add sockopt SCTP_ADD_STREAMS in rfc6525 section > 6.3.4 for user

Re: [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-19 Thread Marcelo Ricardo Leitner
On Fri, Jan 20, 2017 at 01:19:14AM +0800, Xin Long wrote: > This patch is to implement Sender-Side Procedures for the Add > Outgoing and Incoming Streams Request Parameter described in > rfc6525 section 5.1.5-5.1.6. > > It is also to add sockopt SCTP_ADD_STREAMS in rfc6525 section > 6.3.4 for user

Re: [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-19 Thread Marcelo Ricardo Leitner
On Thu, Jan 19, 2017 at 03:17:18PM -0500, Neil Horman wrote: > On Fri, Jan 20, 2017 at 01:19:14AM +0800, Xin Long wrote: > > This patch is to implement Sender-Side Procedures for the Add > > Outgoing and Incoming Streams Request Parameter described in > > rfc6525 section 5.1.5-5.1.6. > > > > It is

Re: [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-19 Thread Marcelo Ricardo Leitner
On Fri, Jan 20, 2017 at 01:19:14AM +0800, Xin Long wrote: > This patch is to implement Sender-Side Procedures for the Add > Outgoing and Incoming Streams Request Parameter described in > rfc6525 section 5.1.5-5.1.6. > > It is also to add sockopt SCTP_ADD_STREAMS in rfc6525 section > 6.3.4 for user

Re: [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-20 Thread Xin Long
On Fri, Jan 20, 2017 at 6:15 AM, Marcelo Ricardo Leitner wrote: > On Fri, Jan 20, 2017 at 01:19:14AM +0800, Xin Long wrote: >> This patch is to implement Sender-Side Procedures for the Add >> Outgoing and Incoming Streams Request Parameter described in >> rfc6525 section 5.1.5-5.1.6. >> >> It is a

Re: [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-20 Thread Xin Long
On Fri, Jan 20, 2017 at 5:47 AM, Marcelo Ricardo Leitner wrote: > On Fri, Jan 20, 2017 at 01:19:14AM +0800, Xin Long wrote: >> This patch is to implement Sender-Side Procedures for the Add >> Outgoing and Incoming Streams Request Parameter described in >> rfc6525 section 5.1.5-5.1.6. >> >> It is a

Re: [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-20 Thread Marcelo Ricardo Leitner
On Fri, Jan 20, 2017 at 04:56:30PM +0800, Xin Long wrote: > On Fri, Jan 20, 2017 at 5:47 AM, Marcelo Ricardo Leitner > wrote: > > On Fri, Jan 20, 2017 at 01:19:14AM +0800, Xin Long wrote: > >> This patch is to implement Sender-Side Procedures for the Add > >> Outgoing and Incoming Streams Request

RE: [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-23 Thread David Laight
From: Xin Long > Sent: 19 January 2017 17:19 > This patch is to implement Sender-Side Procedures for the Add > Outgoing and Incoming Streams Request Parameter described in > rfc6525 section 5.1.5-5.1.6. > > It is also to add sockopt SCTP_ADD_STREAMS in rfc6525 section > 6.3.4 for users. ... > +

Re: [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-23 Thread Neil Horman
On Thu, Jan 19, 2017 at 08:18:13PM -0200, Marcelo Ricardo Leitner wrote: > On Thu, Jan 19, 2017 at 03:17:18PM -0500, Neil Horman wrote: > > On Fri, Jan 20, 2017 at 01:19:14AM +0800, Xin Long wrote: > > > This patch is to implement Sender-Side Procedures for the Add > > > Outgoing and Incoming Strea

Re: [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-23 Thread Neil Horman
On Mon, Jan 23, 2017 at 11:25:56AM +, David Laight wrote: > From: Xin Long > > Sent: 19 January 2017 17:19 > > This patch is to implement Sender-Side Procedures for the Add > > Outgoing and Incoming Streams Request Parameter described in > > rfc6525 section 5.1.5-5.1.6. > > > > It is also to a

Re: [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-23 Thread Marcelo Ricardo Leitner
On Mon, Jan 23, 2017 at 09:53:47AM -0500, Neil Horman wrote: > On Mon, Jan 23, 2017 at 11:25:56AM +, David Laight wrote: > > From: Xin Long > > > Sent: 19 January 2017 17:19 > > > This patch is to implement Sender-Side Procedures for the Add > > > Outgoing and Incoming Streams Request Parameter

Re: [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-23 Thread Marcelo Ricardo Leitner
On Mon, Jan 23, 2017 at 11:25:56AM +, David Laight wrote: > From: Xin Long > > Sent: 19 January 2017 17:19 > > This patch is to implement Sender-Side Procedures for the Add > > Outgoing and Incoming Streams Request Parameter described in > > rfc6525 section 5.1.5-5.1.6. > > > > It is also to a

RE: [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-24 Thread David Laight
From: Marcelo Ricardo Leitner > Sent: 23 January 2017 18:48 > On Mon, Jan 23, 2017 at 11:25:56AM +, David Laight wrote: > > From: Xin Long > > > Sent: 19 January 2017 17:19 > > > This patch is to implement Sender-Side Procedures for the Add > > > Outgoing and Incoming Streams Request Parameter

RE: [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-24 Thread David Laight
From: Marcelo Ricardo Leitner > Sent: 23 January 2017 16:03 ... > > > Does kcalloc() zero the entire area, or just the length you ask for? > > > If the latter you need to zero the rest here. > > Better still, just use krealloc. You still need to zero out any space > > beyond > > the old length, b

Re: [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-24 Thread 'Marcelo Ricardo Leitner'
On Tue, Jan 24, 2017 at 12:35:39PM +, David Laight wrote: > From: Marcelo Ricardo Leitner > > Sent: 23 January 2017 16:03 > ... > > > > Does kcalloc() zero the entire area, or just the length you ask for? > > > > If the latter you need to zero the rest here. > > > Better still, just use kreallo

Re: [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-24 Thread 'Marcelo Ricardo Leitner'
On Tue, Jan 24, 2017 at 12:34:06PM +, David Laight wrote: > From: Marcelo Ricardo Leitner > > Sent: 23 January 2017 18:48 > > On Mon, Jan 23, 2017 at 11:25:56AM +, David Laight wrote: > > > From: Xin Long > > > > Sent: 19 January 2017 17:19 > > > > This patch is to implement Sender-Side Pro