When we share an action within a filter, the bind refcnt
should increase, therefore we should not call tcf_hash_release().
Cc: Jamal Hadi Salim
Cc: Daniel Borkmann
Signed-off-by: Cong Wang
Signed-off-by: Cong Wang
---
net/sched/act_mirred.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
On 07/31/2015 02:12 AM, Cong Wang wrote:
When we share an action within a filter, the bind refcnt
should increase, therefore we should not call tcf_hash_release().
Cc: Jamal Hadi Salim
Cc: Daniel Borkmann
Signed-off-by: Cong Wang
Signed-off-by: Cong Wang
---
net/sched/act_mirred.c | 2 ++
On Fri, Jul 31, 2015 at 3:06 AM, Daniel Borkmann wrote:
> Did you test all variants on this?
>
> I.e. what happens when you replace an existing one, I think the
> refcnt should also be dropped here. It looks like we only drop
> it, in case we tried to add an action to an already existing index ...
On 08/01/2015 12:25 AM, Cong Wang wrote:
On Fri, Jul 31, 2015 at 3:06 AM, Daniel Borkmann wrote:
Did you test all variants on this?
I.e. what happens when you replace an existing one, I think the
refcnt should also be dropped here. It looks like we only drop
it, in case we tried to add an acti
From: Cong Wang
Date: Thu, 30 Jul 2015 17:12:20 -0700
> When we share an action within a filter, the bind refcnt
> should increase, therefore we should not call tcf_hash_release().
>
> Cc: Jamal Hadi Salim
> Cc: Daniel Borkmann
> Signed-off-by: Cong Wang
> Signed-off-by: Cong Wang
Applied,
